Page MenuHomeFreeBSD

DTrace: document the "nolibs" option
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Apr 1 2021, 8:50 PM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

allanjude added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
608

It might be worth mentioning the /usr/lib/dtrace path, and that this can be used to resolve the error jhb was running into.

Infact, it might be worth putting the exact error message here, so that search results for that error lead to this man page.

Thanks. Would you also consider documenting -x libdir and -x syslibdir while here?

This revision is now accepted and ready to land.Apr 1 2021, 8:57 PM

Added -x libdir and -x syslibdir as suggested by @markj

This revision now requires review to proceed.Apr 1 2021, 9:21 PM
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
608

It might be worth doing -- will update the diff again once jhb gives me the exact error message.

cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
635

"Defaults to .Pa /usr/lib/dtrace ."

cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
608

There are lots of error messages that can arise when parsing scripts in /usr/lib/dtrace.

@markj 's comments.

cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
608

That's true -- and the error message in this particular case doesn't really seem like a great one to begin with:

dtrace: invalid probe specifier fbt::vn_sendfile:return { trace(arg1) }: "/usr/lib/dtrace/io.d", line 1: cannot find type: struct devstat*: Type information is in parent and unavailable

Perhaps if we want to avoid confusion here, the right thing is to change the "invalid probe specifier" error message to something more meaningful?

markj added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
608

This is definitely something we can do better... I'll just say that the error handling in libdtrace is really quite hard to follow, there's some setjmp/longjmp and complicated interactions with the generated lexer and parser. So it may be an easy change, but also quite possibly is not an easy change.

637
This revision is now accepted and ready to land.Apr 1 2021, 9:59 PM
This revision now requires review to proceed.Apr 1 2021, 10:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2021, 9:52 PM
This revision was automatically updated to reflect the committed changes.