LinuxKPI: add support for crc32_le()
ClosedPublic
Actions

Authored by bz on Mar 10 2021, 3:13 PM.

Details

Reviewers

tuexen
arichardson
markj
kib
hselasky

Group Reviewers

linuxkpi

Commits

rGb3096b49f97e: LinuxKPI: add support for crc32_le()
rG0c7b75f12840: LinuxKPI: add support for crc32_le()

Summary

Add support for crc32_le() as a wrapper around crc32_raw().

Sponsored-by:	The FreeBSD Foundation
Obtained-from:	bz_iwlwifi
MFC after:	2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz created this revision.Mar 10 2021, 3:13 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 10 2021, 3:13 PM

bz requested review of this revision.Mar 10 2021, 3:13 PM

Harbormaster completed remote builds in B37728: Diff 85483.Mar 10 2021, 3:13 PM

I added some of you as reviewers as you have lately touched the crc32 code and I'd love a separate pair of eyes confirming that byte order for this is correct.

Add @kib and @hselasky as I still cannot see you as memebers of linuxkpi?

manu added a subscriber: manu.Mar 10 2021, 3:21 PM

manu added inline comments.

sys/compat/linuxkpi/common/include/linux/crc32.h
30	s/LINUC/LINUX/

hselasky added inline comments.Mar 10 2021, 7:32 PM

sys/compat/linuxkpi/common/include/linux/crc32.h
30	LINUC -> LINUX

Try to correcctellyy spell1lll LUNIX.

Harbormaster completed remote builds in B37739: Diff 85504.Mar 10 2021, 7:41 PM

hselasky accepted this revision.Mar 10 2021, 8:17 PM

This revision is now accepted and ready to land.Mar 10 2021, 8:17 PM

Closed by commit rG0c7b75f12840: LinuxKPI: add support for crc32_le() (authored by bz). · Explain WhyMar 18 2021, 11:06 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG0c7b75f12840: LinuxKPI: add support for crc32_le().

bz added a commit: rGb3096b49f97e: LinuxKPI: add support for crc32_le().Jul 18 2021, 12:36 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

crc32.h

45 lines

Diff 85958

View Options

sys/compat/linuxkpi/common/include/linux/crc32.h

LinuxKPI: add support for crc32_le()ClosedPublicActions