Page MenuHomeFreeBSD
Differential D29104

domainset: Define additional global policies
ClosedPublic
Actions

Authored by markj on Mar 5 2021, 10:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 11:42 AM
Unknown Object (File)
Sat, Nov 16, 11:34 AM
Unknown Object (File)
Sat, Nov 16, 10:43 AM
Unknown Object (File)
Tue, Oct 29, 11:12 PM
Unknown Object (File)
Oct 8 2024, 10:04 AM
Unknown Object (File)
Sep 29 2024, 5:37 AM
Unknown Object (File)
Sep 28 2024, 11:17 AM
Unknown Object (File)
Sep 28 2024, 9:30 AM
View All 72 Files
Subscribers
allanjude
gbe
imp
mav

Details

Reviewers
mav
Group Reviewers
manpages
Commits
rGbbf46d33a668: domainset: Define additional global policies
rG29bb6c19f044: domainset: Define additional global policies
Summary

Add global definitions for first-touch and interleave policies. The
former will be used in UMA.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mar 5 2021, 10:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2021, 10:51 PM
markj requested review of this revision.Mar 5 2021, 10:51 PM
markj added a child revision: D29105: uma: Implement a non-strict first-touch policy for slab allocation.
Harbormaster completed remote builds in B37631: Diff 85248.Mar 5 2021, 10:52 PM
allanjude added a subscriber: allanjude.Apr 1 2021, 7:26 PM
allanjude added inline comments.
sys/sys/domainset.h
107

Don't we need:

#define DOMAINSET_IL()		 (&domainset_interleave)

as well?

markj updated this revision to Diff 86709.Apr 1 2021, 8:13 PM
  • Add DOMAINSET_IL()
  • Update domainset.9
Herald added a reviewer: manpages. · View Herald TranscriptApr 1 2021, 8:13 PM
Harbormaster completed remote builds in B38261: Diff 86709.Apr 1 2021, 8:13 PM
gbe accepted this revision as: manpages.Apr 5 2021, 10:41 AM
gbe added a subscriber: gbe.

LGTM for the man page parts.

markj mentioned this in D29105: uma: Implement a non-strict first-touch policy for slab allocation.Apr 8 2021, 6:44 PM
mav added a subscriber: mav.Apr 8 2021, 7:16 PM
mav added inline comments.
sys/kern/kern_cpuset.c
1626

Shouldn't cpuset_zero always match domainset0 without having custom knowledge that DOMAINSET_FT() is the default now?

sys/sys/domainset.h
98

There should also be domainset_interleave declaration.

markj marked 2 inline comments as done.Apr 8 2021, 8:43 PM
markj added inline comments.
sys/kern/kern_cpuset.c
1626

Thanks, yes, it was an oversight.

markj updated this revision to Diff 87074.Apr 8 2021, 9:07 PM
markj marked an inline comment as done.

Address feedback.

Harbormaster completed remote builds in B38435: Diff 87074.Apr 8 2021, 9:07 PM
mav accepted this revision.Apr 8 2021, 9:10 PM
This revision is now accepted and ready to land.Apr 8 2021, 9:10 PM
Closed by commit rG29bb6c19f044: domainset: Define additional global policies (authored by markj). · Explain WhyApr 14 2021, 5:04 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG29bb6c19f044: domainset: Define additional global policies.
markj added a commit: rGbbf46d33a668: domainset: Define additional global policies.Apr 28 2021, 2:10 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
20 lines
sys/
kern/
38 lines
sys/
4 lines

Diff 87448

View Options

share/man/man9/domainset.9

Loading...
View Options

sys/kern/kern_cpuset.c

Loading...
View Options

sys/sys/domainset.h

Loading...