ivrs_drv: Fix IVHDs with duplicated BaseAddress
ClosedPublic
Actions

Authored by khng on Feb 26 2021, 6:03 PM.

Details

Reviewers

anish
lwhsu
jhb
philip

Group Reviewers

bhyve

Commits

rG17162a06159a: ivrs_drv: Fix IVHDs with duplicated BaseAddress
rGc5345a05ce7d: ivrs_drv: Fix IVHDs with duplicated BaseAddress
rGede14736fd6d: ivrs_drv: Fix IVHDs with duplicated BaseAddress

Summary

This is partially related to https://lists.freebsd.org/pipermail/freebsd-virtualization/2019-February/007224.html.

Submitted by: Ka Ho Ng <khng300@gmail.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37414
Build 34303: arc lint + arc unit

Event Timeline

khng created this revision.Feb 26 2021, 6:03 PM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 26 2021, 6:03 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

khng requested review of this revision.Feb 26 2021, 6:03 PM

Harbormaster completed remote builds in B37414: Diff 84756.Feb 26 2021, 6:03 PM

khng added a reviewer: lwhsu.Feb 26 2021, 6:03 PM

khng planned changes to this revision.Feb 26 2021, 8:08 PM

I forgot to remove ivhd_hdrs[i-1] = ivhd_hdrs[i];
Removed.

Harbormaster completed remote builds in B37420: Diff 84765.Feb 26 2021, 8:20 PM

khng edited the summary of this revision. (Show Details)Feb 26 2021, 8:27 PM

khng edited the summary of this revision. (Show Details)

jhb accepted this revision.Feb 26 2021, 9:16 PM

This revision is now accepted and ready to land.Feb 26 2021, 9:16 PM

khng added a child revision: D28984: AMD-vi: Fix IOMMU device interrupts being overridden.Mar 1 2021, 6:15 AM

khng added a reviewer: philip.Mar 21 2021, 6:29 PM

Approved by: philip (mentor)

Closed by commit rGede14736fd6d: ivrs_drv: Fix IVHDs with duplicated BaseAddress (authored by khng). · Explain WhyMar 22 2021, 9:34 AM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rGede14736fd6d: ivrs_drv: Fix IVHDs with duplicated BaseAddress.

khng added a commit: rGc5345a05ce7d: ivrs_drv: Fix IVHDs with duplicated BaseAddress.Apr 7 2021, 10:56 AM

khng added a commit: rG17162a06159a: ivrs_drv: Fix IVHDs with duplicated BaseAddress.Sep 3 2021, 7:06 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

amd/

ivrs_drv.c

4 lines

Diff 84756

View Options

sys/amd64/vmm/amd/ivrs_drv.c

ivrs_drv: Fix IVHDs with duplicated BaseAddressClosedPublicActions