Differential D28890

Use pmap_qenter in the N1SDP PCIe driver
ClosedPublic
Actions

Authored by andrew on Feb 23 2021, 1:46 PM.

Details

Reviewers

Group Reviewers

arm64

Commits

rG59f6ddb2bc9c: Use pmap_qenter in the N1SDP PCIe driver

Summary

In the Neoverse N1 SDP PCIe driver we need to map a page shared
between the firmware and the kernel. Previously we would use
pmap_kenter for this, however as this is not standardised between
architectures switch to the common pmap_qenter.

While here fix the error handling code to clean up on failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Feb 23 2021, 1:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2021, 1:46 PM

andrew requested review of this revision.Feb 23 2021, 1:46 PM

Harbormaster completed remote builds in B37304: Diff 84535.Feb 23 2021, 1:46 PM

Booted fine. All my PCI cards work fine.

sys/dev/pci/controller/pci_n1sdp.c
124	No need to wrap. There is enough space on previous line for this.

This revision is now accepted and ready to land.Feb 23 2021, 6:30 PM

Closed by commit rG59f6ddb2bc9c: Use pmap_qenter in the N1SDP PCIe driver (authored by andrew). · Explain WhyFeb 25 2021, 12:47 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG59f6ddb2bc9c: Use pmap_qenter in the N1SDP PCIe driver.

ehem_freebsd_m5p.com mentioned this in D28832: arm64: Rename pmap_kenter() to pmap_kenter_arm64().Feb 26 2021, 2:03 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

controller/

pci_n1sdp.c

39 lines

Diff 84671

View Options

sys/dev/pci/controller/pci_n1sdp.c

Use pmap_qenter in the N1SDP PCIe driverClosedPublicActions