Page MenuHomeFreeBSD

Fix ptrace_test:ptrace__syscall_args after ATF upgrade
ClosedPublic

Authored by arichardson on Tue, Feb 23, 12:51 PM.

Details

Summary

ATF now opens the results file (without CLOEXEC), so the child actually
has a valid file descriptor 3. To fix this simply use a large number that
will definitely not be a valid file descriptor.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Tue, Feb 23, 4:33 PM
lwhsu added inline comments.
tests/sys/kern/ptrace_test.c
4053

Should we put the same comment as the above?

How annoying of ATF to not run tests in a controlled environment. :(

tests/sys/kern/ptrace_test.c
3950–3951

The rest of this file doesn't use comments on the side. I'd probably just drop it, or move it up as a single line comment above with the blank line before.

tests/sys/kern/ptrace_test.c
3950–3951

I would keep the comment, this seems surprising otherwise. It could go on the line above if desired for consistency.

This revision was automatically updated to reflect the committed changes.
arichardson marked 2 inline comments as done.