Page MenuHomeFreeBSD
Differential D28889

Fix ptrace_test:ptrace__syscall_args after ATF upgrade
ClosedPublic
Actions

Authored by arichardson on Feb 23 2021, 12:51 PM.
Tags
None
Referenced Files
F134045022: D28889.diff
Thu, Oct 30, 7:19 AM
Unknown Object (File)
Wed, Oct 29, 9:52 AM
Unknown Object (File)
Wed, Oct 22, 6:40 AM
Unknown Object (File)
Fri, Oct 17, 9:29 AM
Unknown Object (File)
Fri, Oct 17, 2:55 AM
Unknown Object (File)
Thu, Oct 16, 6:20 PM
Unknown Object (File)
Thu, Oct 16, 3:35 PM
Unknown Object (File)
Wed, Oct 15, 2:11 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
jhb
cem
lwhsu
Commits
rG2726b46353a9: Fix ptrace_test:ptrace__syscall_args after ATF upgrade
rG17cc20092cd7: Fix ptrace_test:ptrace__syscall_args after ATF upgrade
Summary

ATF now opens the results file (without CLOEXEC), so the child actually
has a valid file descriptor 3. To fix this simply use a large number that
will definitely not be a valid file descriptor.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Feb 23 2021, 12:51 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 23 2021, 12:51 PM
arichardson requested review of this revision.Feb 23 2021, 12:51 PM
Harbormaster completed remote builds in B37303: Diff 84532.Feb 23 2021, 12:52 PM
cem accepted this revision.Feb 23 2021, 4:33 PM
This revision is now accepted and ready to land.Feb 23 2021, 4:33 PM
lwhsu accepted this revision.Feb 24 2021, 3:46 AM
lwhsu added inline comments.
tests/sys/kern/ptrace_test.c
4053

Should we put the same comment as the above?

jhb accepted this revision.Feb 25 2021, 7:50 PM

How annoying of ATF to not run tests in a controlled environment. :(

tests/sys/kern/ptrace_test.c
3950–3951

The rest of this file doesn't use comments on the side. I'd probably just drop it, or move it up as a single line comment above with the blank line before.

emaste added inline comments.Feb 26 2021, 4:23 AM
tests/sys/kern/ptrace_test.c
3950–3951

I would keep the comment, this seems surprising otherwise. It could go on the line above if desired for consistency.

arichardson added a parent revision: D28887: ptrace_test: Add more debug output on test failures.Mar 1 2021, 2:29 PM
Closed by commit rG17cc20092cd7: Fix ptrace_test:ptrace__syscall_args after ATF upgrade (authored by arichardson). · Explain WhyMar 1 2021, 7:56 PM
This revision was automatically updated to reflect the committed changes.
arichardson marked 2 inline comments as done.
arichardson added a commit: rG17cc20092cd7: Fix ptrace_test:ptrace__syscall_args after ATF upgrade.
arichardson added a commit: rG2726b46353a9: Fix ptrace_test:ptrace__syscall_args after ATF upgrade.Mar 17 2021, 2:06 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
5 lines

Diff 84918

View Options

tests/sys/kern/ptrace_test.c

Loading...