Page MenuHomeFreeBSD

Fix ptrace_test:ptrace__syscall_args after ATF upgrade
ClosedPublic

Authored by arichardson on Feb 23 2021, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 6:20 PM
Unknown Object (File)
Feb 14 2024, 1:56 PM
Unknown Object (File)
Jan 16 2024, 7:01 PM
Unknown Object (File)
Dec 23 2023, 1:28 AM
Unknown Object (File)
Dec 19 2023, 10:04 PM
Unknown Object (File)
Dec 11 2023, 7:09 AM
Unknown Object (File)
Oct 7 2023, 1:14 AM
Unknown Object (File)
Aug 29 2023, 7:21 AM
Subscribers

Details

Summary

ATF now opens the results file (without CLOEXEC), so the child actually
has a valid file descriptor 3. To fix this simply use a large number that
will definitely not be a valid file descriptor.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37303
Build 34192: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 23 2021, 4:33 PM
lwhsu added inline comments.
tests/sys/kern/ptrace_test.c
4070

Should we put the same comment as the above?

How annoying of ATF to not run tests in a controlled environment. :(

tests/sys/kern/ptrace_test.c
3968

The rest of this file doesn't use comments on the side. I'd probably just drop it, or move it up as a single line comment above with the blank line before.

tests/sys/kern/ptrace_test.c
3968

I would keep the comment, this seems surprising otherwise. It could go on the line above if desired for consistency.

This revision was automatically updated to reflect the committed changes.
arichardson marked 2 inline comments as done.