ATF now opens the results file (without CLOEXEC), so the child actually
has a valid file descriptor 3. To fix this simply use a large number that
will definitely not be a valid file descriptor.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| tests/sys/kern/ptrace_test.c | ||
|---|---|---|
| 4053 | Should we put the same comment as the above? | |
Comment Actions
How annoying of ATF to not run tests in a controlled environment. :(
| tests/sys/kern/ptrace_test.c | ||
|---|---|---|
| 3950–3951 | The rest of this file doesn't use comments on the side. I'd probably just drop it, or move it up as a single line comment above with the blank line before. | |
| tests/sys/kern/ptrace_test.c | ||
|---|---|---|
| 3950–3951 | I would keep the comment, this seems surprising otherwise. It could go on the line above if desired for consistency. | |