Paths

Table of Contentst

aarch64: Clear TLS registers during exec().
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:52 PM.

Details

Reviewers

andrew
manu

Group Reviewers

arm64

Commits

rG0723b409150a: aarch64: Clear TLS registers during exec().

Summary

These are not stored in the trapframe so must be cleared explicitly.

This is similar to one of the MIPS changes in 822d2d6ac94f.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Feb 16 2021, 6:52 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 16 2021, 6:52 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B37061: Diff 84028.Feb 16 2021, 6:52 PM

jhb requested review of this revision.Feb 16 2021, 6:52 PM

andrew added inline comments.Mar 4 2021, 6:13 PM

sys/arm64/arm64/machdep.c
565–566	Does `td == curthread` always hold here?

andrew added a reviewer: arm64.Mar 4 2021, 6:14 PM

arichardson added a subscriber: arichardson.Mar 4 2021, 6:18 PM

Do we need this for linux_exec_setregs?

jhb added inline comments.Mar 9 2021, 9:51 PM

sys/arm64/arm64/machdep.c
565–566	Yes.

In D28711#651003, @arichardson wrote:

Do we need this for linux_exec_setregs?

Hmm, possibly.

Cleared in linux_exec_setregs().

Harbormaster completed remote builds in B37876: Diff 85860.Mar 16 2021, 11:17 PM

andrew accepted this revision.Mar 17 2021, 9:15 AM

This revision is now accepted and ready to land.Mar 17 2021, 9:15 AM

Closed by commit rG0723b409150a: aarch64: Clear TLS registers during exec(). (authored by jhb). · Explain WhyMar 17 2021, 8:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0723b409150a: aarch64: Clear TLS registers during exec()..

Revision Contents
Changeset List

Path

Size

sys/

arm64/

machdep.c

5 lines

linux/

linux_sysvec.c

5 lines

Diff 85928

View Options

sys/arm64/arm64/machdep.c