tmpfs: push VEXEC check into tmpfs_lookup()
ClosedPublic
Actions

Authored by kevans on Jan 28 2021, 3:49 PM.

Details

Reviewers

arichardson
kib

Commits

rG0f919ed4ae4d: tmpfs: push VEXEC check into tmpfs_lookup()

Summary

vfs_cache_lookup() has already done the appropriate VEXEC check, therefore
we must not re-check in VOP_CACHEDLOOKUP.

This fixes O_SEARCH semantics on tmpfs and removes a redundant descent into
VOP_ACCESS() in the common case.

Reported-by: arichardson (via CheriBSD Jenkins CI)
Differential-Revision: https://reviews.freebsd.org/D28401

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 36590
Build 33479: arc lint + arc unit

Event Timeline

kevans created this revision.Jan 28 2021, 3:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2021, 3:49 PM

kevans requested review of this revision.Jan 28 2021, 3:49 PM

Harbormaster completed remote builds in B36577: Diff 83050.Jan 28 2021, 3:49 PM

Maybe Reported-by: arichardson (via CheriBSD Jenkins CI)

kib added inline comments.Jan 28 2021, 5:44 PM

sys/fs/tmpfs/tmpfs_vnops.c
101	Instead of adding cached param, you can move vn_dir_check_exec() into tmpfs_lookup().

Just push the check back into tmpfs_lookup, note in tmpfs_lookup1 that the
caller should have ensured it's a valid access to make sure it's obvious to
readers that it's intentionally omitted from here.

Harbormaster completed remote builds in B36590: Diff 83076.Jan 28 2021, 10:40 PM

kevans retitled this revision from tmpfs: do not recheck for VEXEC in VOP_CACHEDLOOKUP to tmpfs: push VEXEC check into tmpfs_lookup().Jan 28 2021, 10:40 PM

kevans edited the summary of this revision. (Show Details)

kib accepted this revision.Jan 28 2021, 11:03 PM

This revision is now accepted and ready to land.Jan 28 2021, 11:03 PM

Closed by commit rG0f919ed4ae4d: tmpfs: push VEXEC check into tmpfs_lookup() (authored by kevans). · Explain WhyJan 29 2021, 1:26 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG0f919ed4ae4d: tmpfs: push VEXEC check into tmpfs_lookup().