Page MenuHomeFreeBSD

tmpfs: push VEXEC check into tmpfs_lookup()
ClosedPublic

Authored by kevans on Jan 28 2021, 3:49 PM.

Details

Summary

vfs_cache_lookup() has already done the appropriate VEXEC check, therefore
we must not re-check in VOP_CACHEDLOOKUP.

This fixes O_SEARCH semantics on tmpfs and removes a redundant descent into
VOP_ACCESS() in the common case.

Reported-by: arichardson (via CheriBSD Jenkins CI)
Differential-Revision: https://reviews.freebsd.org/D28401

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Maybe Reported-by: arichardson (via CheriBSD Jenkins CI)

sys/fs/tmpfs/tmpfs_vnops.c
101

Instead of adding cached param, you can move vn_dir_check_exec() into tmpfs_lookup().

Just push the check back into tmpfs_lookup, note in tmpfs_lookup1 that the
caller should have ensured it's a valid access to make sure it's obvious to
readers that it's intentionally omitted from here.

kevans retitled this revision from tmpfs: do not recheck for VEXEC in VOP_CACHEDLOOKUP to tmpfs: push VEXEC check into tmpfs_lookup().Jan 28 2021, 10:40 PM
kevans edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 28 2021, 11:03 PM
This revision was automatically updated to reflect the committed changes.