Page MenuHomeFreeBSD

Add git-arc
ClosedPublic

Authored by markj on Jan 25 2021, 5:24 PM.

Details

Summary

This is a script to make it easier to manage phabricator reviews for src
commits. It tries to avoid forcing any particular workflow.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Jan 25 2021, 5:24 PM

I might also be convinced to write a git-arc(8) man-page. ;)

tools/tools/git/git-arc.sh
50

I would recommend s/verb/command/, as that's the syntax used in other places, for example camcontrol(8), which uses (sub)commands too.

I might also be convinced to write a git-arc(8) man-page. ;)

That would be useful. Let's perhaps first wait and see if the interface changes much before I commit.

  • Address feedback, verb -> command in the usage message.
tools/tools/git/git-arc.sh
92

Probably s/upstream/freebsd/ here to match our other git docs.

tools/tools/git/git-arc.sh
92

Agreed.

markj marked an inline comment as done.

Use the canonical name for an upstream FreeBSD remote.

Is it a show-stopper that this script relies on the textproc/jq port?

Is it a show-stopper that this script relies on the textproc/jq port?

I don't really expect so since it already relies on the arcanist port. But we should verify that both packages are installed before trying to do anything...

Check for jq and arc before trying to do anything.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 5, 2:48 PM
This revision was automatically updated to reflect the committed changes.