Page MenuHomeFreeBSD

Add git-arc
ClosedPublic

Authored by markj on Jan 25 2021, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 3:51 PM
Unknown Object (File)
Feb 8 2024, 12:07 AM
Unknown Object (File)
Dec 21 2023, 4:01 PM
Unknown Object (File)
Dec 14 2023, 8:15 PM
Unknown Object (File)
Nov 30 2023, 5:47 AM
Unknown Object (File)
Nov 26 2023, 9:06 AM
Unknown Object (File)
Nov 26 2023, 9:06 AM
Unknown Object (File)
Nov 26 2023, 9:06 AM

Details

Summary

This is a script to make it easier to manage phabricator reviews for src
commits. It tries to avoid forcing any particular workflow.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36472
Build 33361: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jan 25 2021, 5:24 PM

I might also be convinced to write a git-arc(8) man-page. ;)

tools/tools/git/git-arc.sh
50

I would recommend s/verb/command/, as that's the syntax used in other places, for example camcontrol(8), which uses (sub)commands too.

I might also be convinced to write a git-arc(8) man-page. ;)

That would be useful. Let's perhaps first wait and see if the interface changes much before I commit.

  • Address feedback, verb -> command in the usage message.
tools/tools/git/git-arc.sh
93

Probably s/upstream/freebsd/ here to match our other git docs.

tools/tools/git/git-arc.sh
93

Agreed.

markj marked an inline comment as done.

Use the canonical name for an upstream FreeBSD remote.

Is it a show-stopper that this script relies on the textproc/jq port?

Is it a show-stopper that this script relies on the textproc/jq port?

I don't really expect so since it already relies on the arcanist port. But we should verify that both packages are installed before trying to do anything...

Check for jq and arc before trying to do anything.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 5 2021, 2:48 PM
Closed by commit rG3279329b2dca: tools/git: Add git-arc (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.