Page MenuHomeFreeBSD
Differential D2828

ARP request proper locking handling
ClosedPublic
Actions

Authored by eri on Jun 15 2015, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 7:08 AM
Unknown Object (File)
Fri, Nov 29, 10:36 AM
Unknown Object (File)
Nov 23 2024, 2:37 PM
Unknown Object (File)
Nov 20 2024, 4:25 AM
Unknown Object (File)
Nov 19 2024, 3:01 PM
Unknown Object (File)
Oct 27 2024, 1:07 PM
Unknown Object (File)
Oct 21 2024, 3:16 AM
Unknown Object (File)
Oct 18 2024, 7:04 AM
View All Files
Subscribers
ae
franco_opnsense.org
imp
jim_netgate.com
koobs
lattera-gmail.com

Details

Reviewers
ae
gnn
Group Reviewers
network
Commits
rS284512: If there is a system with a bpf consumer running and a packet is wanted
Summary

If there is a system with a bpf consumer running and with direct dispatch policy on an expired arp entry can crash the system if the bpf code wants to sleep when called.

Also described here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

eri updated this revision to Diff 6211.Jun 15 2015, 4:59 PM
eri retitled this revision from to ARP request proper locking handling.
eri updated this object.
eri edited the test plan for this revision. (Show Details)
eri added reviewers: network, gnn.
eri set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2015, 4:59 PM
koobs added a subscriber: koobs.Jun 15 2015, 5:05 PM
lattera-gmail.com added a subscriber: lattera-gmail.com.Jun 15 2015, 5:38 PM
jim_netgate.com added a subscriber: jim_netgate.com.Jun 15 2015, 6:06 PM
franco_opnsense.org added a subscriber: franco_opnsense.org.Jun 15 2015, 8:52 PM
franco_opnsense.org added a comment.Jun 15 2015, 9:02 PM

It's highly likely that LLE_EXCLUSIVE is always set since la_preempt is being modified. The other code branch of arpresolve() calling arprequest() is modifying/unlocking la in the same way. Cheers for tracking this down.

ae accepted this revision.Jun 15 2015, 10:10 PM
ae added a reviewer: ae.
ae added a subscriber: ae.

Looks correct to me.

This revision is now accepted and ready to land.Jun 15 2015, 10:10 PM
gnn accepted this revision.Jun 16 2015, 2:29 AM
gnn edited edge metadata.

Accepted by mentor as well. Please commit.

Closed by commit rS284512: If there is a system with a bpf consumer running and a packet is wanted (authored by eri). · Explain WhyJun 17 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netinet/
15 lines

Diff 6211

View Options

sys/netinet/if_ether.c

Loading...