bhyve/vioapic: remove an extra pin masked check
ClosedPublic
Actions

Authored by royger on Jan 19 2021, 2:25 PM.

Details

Reviewers

Group Reviewers

Commits

rG0e622d39414a: bhyve/vioapic: remove an extra pin masked check
rG49429cf9be7f: bhyve/vioapic: remove an extra pin masked check

Summary

vioapic_send_intr does already check whether the pin is masked before
injecting the interrupt, there's no need to do it in vioapic_write
also.

No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36338
Build 33227: arc lint + arc unit

Event Timeline

royger created this revision.Jan 19 2021, 2:25 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 19 2021, 2:25 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

royger requested review of this revision.Jan 19 2021, 2:25 PM

Harbormaster completed remote builds in B36338: Diff 82568.Jan 19 2021, 2:25 PM

grehan accepted this revision.Feb 2 2021, 8:21 AM

This revision is now accepted and ready to land.Feb 2 2021, 8:21 AM

Closed by commit rG49429cf9be7f: bhyve/vioapic: remove an extra pin masked check (authored by royger). · Explain WhyFeb 2 2021, 8:50 AM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG49429cf9be7f: bhyve/vioapic: remove an extra pin masked check.

jhb added a commit: rG0e622d39414a: bhyve/vioapic: remove an extra pin masked check.Jan 26 2023, 6:35 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

io/

vioapic.c

4 lines

Diff 82568

View Options

sys/amd64/vmm/io/vioapic.c

bhyve/vioapic: remove an extra pin masked checkClosedPublicActions