Remove redundant rtinit() calls from tuntap.
ClosedPublic
Actions

Authored by melifaro on Jan 11 2021, 11:35 PM.

Tags

None

Referenced Files

	F170725943: D28106.id82120.diff
	Sun, Sep 6, 6:01 AM

	F170721101: D28106.id82120.diff
	Sun, Sep 6, 5:22 AM

	F170708515: D28106.id.diff
	Sun, Sep 6, 3:33 AM

	Unknown Object (File)
	Sat, Sep 5, 1:38 PM

	Unknown Object (File)
	Thu, Sep 3, 8:34 PM

	Unknown Object (File)
	Thu, Sep 3, 4:31 AM

	Unknown Object (File)
	Wed, Sep 2, 3:00 PM

	Unknown Object (File)
	Wed, Sep 2, 1:42 PM

View All Files

Subscribers

imp

Details

Reviewers

glebius

Group Reviewers

network

Commits

rGa6b7689718d2: Remove redundant rtinit() calls from tuntap.

Summary

Removed code iterates over if_addrhead and tries to remove
routes for each ifa.
This is exactly the thing that if_purgeaddrs() do, and
if_purgeaddr() is already called in the end.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Jan 11 2021, 11:35 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 11 2021, 11:35 PM

melifaro requested review of this revision.Jan 11 2021, 11:35 PM

Harbormaster completed remote builds in B36125: Diff 82120.Jan 11 2021, 11:35 PM

glebius accepted this revision.Jan 12 2021, 4:30 PM

This revision is now accepted and ready to land.Jan 12 2021, 4:30 PM

Closed by commit rGa6b7689718d2: Remove redundant rtinit() calls from tuntap. (authored by melifaro). · Explain WhyJan 13 2021, 10:07 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGa6b7689718d2: Remove redundant rtinit() calls from tuntap..

Revision Contents
Changeset List

Path

Size

sys/

net/

if_tuntap.c

32 lines

Diff 82197

View Options

Remove redundant rtinit() calls from tuntap.ClosedPublicActions