Differential D26714

Add DSCP support for network QoS to iscsi initiator.
ClosedPublic
Actions

Authored by rscheff on Oct 8 2020, 12:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 20, 6:29 PM

	Unknown Object (File)
	Mar 16 2024, 4:30 AM

	Unknown Object (File)
	Mar 16 2024, 4:30 AM

	Unknown Object (File)
	Mar 16 2024, 4:24 AM

	Unknown Object (File)
	Mar 16 2024, 4:24 AM

	Unknown Object (File)
	Mar 12 2024, 8:54 AM

	Unknown Object (File)
	Jan 6 2024, 6:08 PM

	Unknown Object (File)
	Jan 6 2024, 6:08 PM

View All 42 Files

Subscribers

Details

Reviewers

mav
trasz
bcr
tuexen
allanjude

Group Reviewers

manpages
NetApp

Commits

rS367019: MFC r366573: Add DSCP support for network QoS to iscsi initiator.
rS366573: Add DSCP support for network QoS to iscsi initiator.

Summary

Similar to D26385, the DSCP codepoing should also
be configurable for the traffic in the direction
from the initiator to the target, such that writes
and any requests are also treated in the appropriate
QoS class.

Test Plan

Verify that the initial TCP packets sent towards
a iscsi target, and all subsequent packets in that
direction, are marked with the configured DSCP value.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34065
Build 31246: arc lint + arc unit

Event Timeline

rscheff requested review of this revision.Oct 8 2020, 12:54 AM

rscheff created this revision.

Harbormaster completed remote builds in B34053: Diff 78003.Oct 8 2020, 12:54 AM

add dscp to man page, and keep equal sign between keywords
output dscp of target only if configured

Harbormaster completed remote builds in B34065: Diff 78021.Oct 8 2020, 6:28 PM

rscheff added reviewers: mav, trasz, manpages, bcr, tuexen, NetApp, allanjude.Oct 8 2020, 6:30 PM

mav accepted this revision.Oct 9 2020, 2:23 PM

This revision is now accepted and ready to land.Oct 9 2020, 2:23 PM

Closed by commit rS366573: Add DSCP support for network QoS to iscsi initiator. (authored by rscheff). · Explain WhyOct 9 2020, 2:33 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rS366573: Add DSCP support for network QoS to iscsi initiator..

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2020, 2:33 PM

rscheff added a commit: rS367019: MFC r366573: Add DSCP support for network QoS to iscsi initiator..Oct 24 2020, 8:52 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iscsi/

3 lines

usr.bin/

iscsictl/

2 lines

10 lines

1 line

5 lines

50 lines

23 lines

usr.sbin/

iscsid/

20 lines

Diff 78021

sys/dev/iscsi/iscsi_ioctl.h

Loading...

usr.bin/iscsictl/Makefile

Loading...

usr.bin/iscsictl/iscsi.conf.5

Loading...

usr.bin/iscsictl/iscsictl.h

Loading...

usr.bin/iscsictl/iscsictl.c

Loading...

usr.bin/iscsictl/parse.y

Loading...

usr.bin/iscsictl/token.l

Loading...

usr.sbin/iscsid/iscsid.c

Loading...