Page MenuHomeFreeBSD
Differential D26540

Eliminate building LINT makefiles
ClosedPublic
Actions

Authored by imp on Sep 23 2020, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 5:02 PM
Unknown Object (File)
Thu, Dec 5, 11:21 PM
Unknown Object (File)
Thu, Dec 5, 11:17 PM
Unknown Object (File)
Thu, Dec 5, 11:17 PM
Unknown Object (File)
Dec 1 2024, 6:12 PM
Unknown Object (File)
Nov 6 2024, 2:22 PM
Unknown Object (File)
Sep 30 2024, 1:43 AM
Unknown Object (File)
Sep 18 2024, 9:21 PM
View All 61 Files
Subscribers
andrew
emaste
jhibbits
kevans
mhorne

Details

Reviewers
manu
kevans
Commits
rS366559: Create in-tree LINT files
rS366560: Remove now-unused files
rS366556: Stop ignoring makeLINT generated files
rS366555: Eliminate building LINT makefiles
Summary

Stop ignoring makeLINT generated files

We're going to check these files in shortly since we don't need to
generate them anymore. Generated files cause issues for different work
flows anyway.

Create in-tree LINT files

Now that config(8) has supported include for 19 years, transition to
including the NOTES files. include support didn't exist at the time,
nor did the envvar stuff recently added. Now that it does, eliminate
the building of LINT files by just including everything you need.

Note: This may cause conflicts with updating in some cases.
find sys -name LINT\* -rm
is suggested across this commit to remove the generated LINT
files.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Sep 23 2020, 10:04 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 23 2020, 10:04 PM
Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript
imp requested review of this revision.Sep 23 2020, 10:04 PM
Harbormaster completed remote builds in B33785: Diff 77462.Sep 23 2020, 10:04 PM
kevans accepted this revision.Sep 23 2020, 11:08 PM
kevans added a subscriber: kevans.

Yup, this matches what I envisioned when you pitched it! =)

This revision is now accepted and ready to land.Sep 23 2020, 11:08 PM
mhorne mentioned this in D26502: RISC-V LINT kernel config.Sep 23 2020, 11:08 PM
mhorne added a subscriber: mhorne.Sep 23 2020, 11:09 PM

I rebased D26502 on top of this and it builds fine.

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

Should these have ident LINT?

imp added inline comments.Sep 23 2020, 11:29 PM
sys/amd64/conf/LINT
2 ↗(On Diff #77462)

works without it.... The current generated LINT files don't have it....

otoh, it won't hurt anything.

mhorne added inline comments.Sep 23 2020, 11:31 PM
sys/amd64/conf/LINT
2 ↗(On Diff #77462)

Let's save the bytes then >:)

kevans added inline comments.Sep 24 2020, 1:28 PM
sys/amd64/conf/LINT
2 ↗(On Diff #77462)

It inherits the IDENT from sys/conf/NOTES in all cases

mhorne added inline comments.Sep 24 2020, 1:52 PM
sys/amd64/conf/LINT
2 ↗(On Diff #77462)

That makes sense. I thought to look in sys/${arch}/conf/NOTES but not there for some reason.

Closed by commit rS366555: Eliminate building LINT makefiles (authored by imp). · Explain WhyOct 9 2020, 12:28 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS366555: Eliminate building LINT makefiles.
imp added a commit: rS366556: Stop ignoring makeLINT generated files.
imp added a commit: rS366560: Remove now-unused files.Oct 9 2020, 1:48 AM
imp added a commit: rS366559: Create in-tree LINT files.

Revision Contents
Changeset List

PathSize
head/
10 lines

Diff 78033

View Options

head/Makefile

Loading...