Page MenuHomeFreeBSD

Eliminate building LINT makefiles
ClosedPublic

Authored by imp on Wed, Sep 23, 10:04 PM.

Details

Summary

Stop ignoring makeLINT generated files

We're going to check these files in shortly since we don't need to
generate them anymore. Generated files cause issues for different work
flows anyway.

Create in-tree LINT files

Now that config(8) has supported include for 19 years, transition to
including the NOTES files. include support didn't exist at the time,
nor did the envvar stuff recently added. Now that it does, eliminate
the building of LINT files by just including everything you need.

Note: This may cause conflicts with updating in some cases.
find sys -name LINT\* -rm
is suggested across this commit to remove the generated LINT
files.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Wed, Sep 23, 10:04 PM
kevans added a subscriber: kevans.

Yup, this matches what I envisioned when you pitched it! =)

This revision is now accepted and ready to land.Wed, Sep 23, 11:08 PM

I rebased D26502 on top of this and it builds fine.

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

Should these have ident LINT?

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

works without it.... The current generated LINT files don't have it....

otoh, it won't hurt anything.

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

Let's save the bytes then >:)

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

It inherits the IDENT from sys/conf/NOTES in all cases

sys/amd64/conf/LINT
2 ↗(On Diff #77462)

That makes sense. I thought to look in sys/${arch}/conf/NOTES but not there for some reason.

This revision was automatically updated to reflect the committed changes.