Page MenuHomeFreeBSD

Get rid of sv_errtbl and SV_ABI_ERRNO()
ClosedPublic

Authored by trasz on Sep 10 2020, 10:35 AM.
Tags
None
Referenced Files
F132251585: D26388.id77063.diff
Wed, Oct 15, 5:07 AM
Unknown Object (File)
Tue, Oct 14, 4:08 PM
Unknown Object (File)
Tue, Oct 14, 4:07 PM
Unknown Object (File)
Fri, Oct 10, 1:40 AM
Unknown Object (File)
Thu, Sep 25, 1:51 PM
Unknown Object (File)
Sat, Sep 20, 2:27 PM
Unknown Object (File)
Thu, Sep 18, 2:46 PM
Unknown Object (File)
Thu, Sep 18, 7:07 AM

Details

Summary

Get rid of sv_errtbl and SV_ABI_ERRNO(). This builds
on https://reviews.freebsd.org/D26378.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/compat/linux/linux_errno.c
23 ↗(On Diff #77058)

This is ERESTART. I do not think it is reasonable return.

sys/sys/sysent.h
162 ↗(On Diff #77058)

.. even if old code did that.

Be more strict on allowed values and don't return -1 (which would be ERESTART).

This revision is now accepted and ready to land.Sep 16 2020, 3:51 PM
This revision was automatically updated to reflect the committed changes.
arichardson added inline comments.
head/sys/compat/linux/linux_errno.c
14

Isn't this name the wrong way around and should be linux_from_bsd_errno(int error) or freebsd_to_linux_errno?

trasz added inline comments.
head/sys/compat/linux/linux_errno.c
14

Indeed - fixed in r367079.