getlogin_r: fix the type of len
ClosedPublic
Actions

Authored by kevans on Sep 5 2020, 2:03 AM.

Details

Reviewers

kib
brooks
cem
emaste
jhb

Group Reviewers

manpages

Commits

rS365506: getlogin_r: fix the type of len

Summary

getlogin_r is specified by POSIX to to take a size_t len, not int. Fix our version to do the same, bump the symbol version due to ABI change and provide compat.

This was reported to break compilation of Ruby 2.8.

PR: 247102
Submitted by: Bertram Scharpf <software@bertram-scharpf.de> (original), cem (ABI compat)
MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 5 2020, 2:03 AM

Herald added a reviewer: manpages. · View Herald TranscriptSep 5 2020, 2:03 AM

Herald added a subscriber: imp. · View Herald Transcript

kevans requested review of this revision.Sep 5 2020, 2:03 AM

Harbormaster completed remote builds in B33409: Diff 76686.Sep 5 2020, 2:04 AM

kib accepted this revision.Sep 5 2020, 9:51 AM

This revision is now accepted and ready to land.Sep 5 2020, 9:51 AM

emaste accepted this revision.Sep 8 2020, 2:45 AM

I suspect it's not even an ABI issue since all our 64-bit platforms would pass 'len' in a 64-bit register that is (probably) zero-extended. However, the shim is cheap.

In D26335#586194, @jhb wrote:

I suspect it's not even an ABI issue since all our 64-bit platforms would pass 'len' in a 64-bit register that is (probably) zero-extended. However, the shim is cheap.

At least mips sign-extends.

Closed by commit rS365506: getlogin_r: fix the type of len (authored by kevans). · Explain WhySep 9 2020, 6:07 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS365506: getlogin_r: fix the type of len.