The condition can never be true
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Aug 21 2020, 3:09 PM.

Details

Reviewers

tsoome
erj
cem
vangyzen

Group Reviewers

Intel Networking

Commits

rS364462: ixgbe: fix impossible condition

Summary

Coverity flagged this condition: The and condition offset == 0 && offset == 65535 can never be true because offset cannot be equal to two different values at the same time

Diff Detail

Repository

rS FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bret_ketchum_dell.com created this revision.Aug 21 2020, 3:09 PM

Herald added a subscriber: ae. · View Herald TranscriptAug 21 2020, 3:09 PM

bret_ketchum_dell.com requested review of this revision.Aug 21 2020, 3:09 PM

lwhsu added a reviewer: Intel Networking.Aug 21 2020, 3:54 PM

The same fix is applied in illumos (detected by smatch).

This revision is now accepted and ready to land.Aug 21 2020, 4:55 PM

lgtm

vangyzen accepted this revision.Aug 21 2020, 7:29 PM

Closed by commit rS364462: ixgbe: fix impossible condition (authored by vangyzen). · Explain WhyAug 21 2020, 7:34 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS364462: ixgbe: fix impossible condition.

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2020, 7:34 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixgbe/

ixgbe_common.c

4 lines

Diff 76074

View Options

head/sys/dev/ixgbe/ixgbe_common.c

The condition can never be trueClosedPublicActions