Page MenuHomeFreeBSD
Differential D26144

The condition can never be true
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Aug 21 2020, 3:09 PM.

Details

Reviewers
tsoome
erj
cem
vangyzen
Group Reviewers
Intel Networking
Commits
rG660b6999cc95: ixgbe: fix impossible condition
rS364462: ixgbe: fix impossible condition
Summary

Coverity flagged this condition: The and condition offset == 0 && offset == 65535 can never be true because offset cannot be equal to two different values at the same time

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bret_ketchum_dell.com created this revision.Aug 21 2020, 3:09 PM
Herald added a subscriber: ae. · View Herald TranscriptAug 21 2020, 3:09 PM
bret_ketchum_dell.com requested review of this revision.Aug 21 2020, 3:09 PM
lwhsu added a reviewer: Intel Networking.Aug 21 2020, 3:54 PM
tsoome accepted this revision.Aug 21 2020, 4:55 PM

The same fix is applied in illumos (detected by smatch).

This revision is now accepted and ready to land.Aug 21 2020, 4:55 PM
cem accepted this revision.Aug 21 2020, 5:28 PM
cem added a subscriber: cem.

lgtm

vangyzen accepted this revision.Aug 21 2020, 7:29 PM
Closed by commit rS364462: ixgbe: fix impossible condition (authored by vangyzen). · Explain WhyAug 21 2020, 7:34 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rS364462: ixgbe: fix impossible condition.
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2020, 7:34 PM
ehem_freebsd_m5p.com mentioned this in D30297: arm64/nexus: use actual PA range for I/O memory limit.May 20 2021, 8:02 PM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG660b6999cc95: ixgbe: fix impossible condition.Oct 3 2021, 5:06 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ixgbe/
4 lines

Diff 76074

View Options

head/sys/dev/ixgbe/ixgbe_common.c

Loading...