Page MenuHomeFreeBSD
Differential D25663

Fix linker error in libuutil with recent LLVM
ClosedPublic
Actions

Authored by arichardson on Jul 14 2020, 10:29 AM.
Tags
None
Referenced Files
F108260469: D25663.diff
Thu, Jan 23, 4:59 AM
Unknown Object (File)
Dec 11 2024, 9:06 AM
Unknown Object (File)
Nov 26 2024, 9:14 AM
Unknown Object (File)
Nov 26 2024, 9:13 AM
Unknown Object (File)
Nov 26 2024, 9:11 AM
Unknown Object (File)
Nov 26 2024, 8:49 AM
Unknown Object (File)
Nov 26 2024, 8:32 AM
Unknown Object (File)
Oct 31 2024, 11:46 PM
View All 42 Files
Subscribers
delphij
imp
mav

Details

Reviewers
asomers
mmacy
freqlabs
mav
Group Reviewers
ZFS
Commits
rS368389: MFC r364027 by arichardson: Fix linker error in libuutil with recent LLVM
rS364027: Fix linker error in libuutil with recent LLVM
Summary

Not marking the function as static can result in a linker error:
undefined reference to __assfail [--no-allow-shlib-undefined]
I noticed this error after updating our CHERI LLVM to the latest upstream
LLVM HEAD revision.

This change effectively reverts r329984 and marks dmu_buf_init_user as static.

Test Plan

compiles again

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 14 2020, 10:29 AM
Herald added a subscriber: delphij. · View Herald TranscriptJul 14 2020, 10:29 AM
arichardson requested review of this revision.Jul 14 2020, 10:29 AM
Harbormaster completed remote builds in B32315: Diff 74433.Jul 14 2020, 10:29 AM
arichardson added a comment.Aug 7 2020, 1:50 PM

ping?

mav added reviewers: mmacy, freqlabs.Aug 7 2020, 1:53 PM
mav accepted this revision.Aug 7 2020, 1:57 PM
mav added a subscriber: mav.

dmu_buf_init_user() part is actually done in OpenZFS already.

__assfail() part looks OK to me too.

This revision is now accepted and ready to land.Aug 7 2020, 1:57 PM
freqlabs accepted this revision.Aug 7 2020, 2:04 PM
asomers added a comment.Aug 7 2020, 2:32 PM

r329984 was done for a reason. With your change, can you still build world with GCC6?

arichardson added a comment.Aug 7 2020, 2:34 PM
In D25663#576378, @asomers wrote:

r329984 was done for a reason. With your change, can you still build world with GCC6?

This patch adds static to dmu_buf_init_user and should therefore fix the error.

asomers accepted this revision.Aug 7 2020, 2:49 PM

Ok. As long as you've tested it with GCC6, then it's fine by me.

Closed by commit rS364027: Fix linker error in libuutil with recent LLVM (authored by arichardson). · Explain WhyAug 7 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS364027: Fix linker error in libuutil with recent LLVM.
Herald added a subscriber: imp. · View Herald TranscriptAug 7 2020, 4:04 PM
eugen added a commit: rS368389: MFC r364027 by arichardson: Fix linker error in libuutil with recent LLVM.Dec 6 2020, 4:22 PM

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
compat/
opensolaris/
sys/
4 lines
contrib/
opensolaris/
uts/
common/
fs/
zfs/
7 lines
sys/
2 lines

Diff 75574

View Options

head/sys/cddl/compat/opensolaris/sys/assfail.h

Loading...
View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c

Loading...
View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu.h

Loading...