Allow install(1)'s create_tempfile() to work on Linux hosts
ClosedPublic
Actions

Authored by arichardson on Jul 14 2020, 9:25 AM.

Details

Reviewers

kevans
emaste
imp
mjg

Group Reviewers

manpages

Commits

rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts

Summary

GLibc expects six 'X' characters in the mkstemp template argument

Test Plan

install(1) no longer fails with EINVAL in certain cases

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Jul 14 2020, 9:25 AM

arichardson created this revision.

Harbormaster completed remote builds in B32312: Diff 74430.Jul 14 2020, 9:25 AM

manpage refers to the string and needs to be updated

Also update manpage

Harbormaster completed remote builds in B32313: Diff 74431.Jul 14 2020, 9:33 AM

In D25662#567794, @mjg wrote:

manpage refers to the string and needs to be updated

Good catch! I was not expecting this string to be used in the documentation so I didn't look at the manpage.

I think a better comment would be that glibc requires at least 6 chars, but I don't think it matters.

This revision is now accepted and ready to land.Jul 14 2020, 10:20 AM

Agree @mjg's comment is a slight improvement

Or you could just remove the comment. I can't imagine anyone ever coming along and reducing the number of random characters again.

Love it...

Closed by commit rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts (authored by arichardson). · Explain WhyJul 15 2020, 5:24 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts.

Herald added a reviewer: manpages. · View Herald TranscriptJul 15 2020, 5:24 PM

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

xinstall/

install.1

8 lines

xinstall.c

2 lines

Diff 74493

View Options

head/usr.bin/xinstall/install.1