Page MenuHomeFreeBSD
Differential D25662

Allow install(1)'s create_tempfile() to work on Linux hosts
ClosedPublic
Actions

Authored by arichardson on Jul 14 2020, 9:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 12:10 AM
Unknown Object (File)
Thu, Apr 11, 7:51 PM
Unknown Object (File)
Sat, Mar 30, 11:49 AM
Unknown Object (File)
Feb 11 2024, 4:14 AM
Unknown Object (File)
Jan 27 2024, 9:40 AM
Unknown Object (File)
Jan 22 2024, 1:08 PM
Unknown Object (File)
Dec 28 2023, 7:43 AM
Unknown Object (File)
Dec 21 2023, 4:37 PM
View All 28 Files
Subscribers
mjg

Details

Reviewers
kevans
emaste
imp
mjg
Group Reviewers
manpages
Commits
rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts
Summary

GLibc expects six 'X' characters in the mkstemp template argument

Test Plan

install(1) no longer fails with EINVAL in certain cases

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32312
Build 29795: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Jul 14 2020, 9:25 AM
arichardson created this revision.
Harbormaster completed remote builds in B32312: Diff 74430.Jul 14 2020, 9:25 AM
mjg added a subscriber: mjg.Jul 14 2020, 9:29 AM

manpage refers to the string and needs to be updated

arichardson updated this revision to Diff 74431.Jul 14 2020, 9:33 AM

Also update manpage

Harbormaster completed remote builds in B32313: Diff 74431.Jul 14 2020, 9:33 AM
arichardson added a comment.Jul 14 2020, 9:33 AM
In D25662#567794, @mjg wrote:

manpage refers to the string and needs to be updated

Good catch! I was not expecting this string to be used in the documentation so I didn't look at the manpage.

mjg accepted this revision.Jul 14 2020, 10:20 AM

I think a better comment would be that glibc requires at least 6 chars, but I don't think it matters.

This revision is now accepted and ready to land.Jul 14 2020, 10:20 AM
emaste accepted this revision.Jul 15 2020, 1:19 AM

Agree @mjg's comment is a slight improvement

emaste added a comment.Jul 15 2020, 1:21 AM

Or you could just remove the comment. I can't imagine anyone ever coming along and reducing the number of random characters again.

imp accepted this revision.Jul 15 2020, 1:22 AM

Love it...

Closed by commit rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts (authored by arichardson). · Explain WhyJul 15 2020, 5:24 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS363230: Allow install(1)'s create_tempfile() to work on Linux hosts.
Herald added a reviewer: manpages. · View Herald TranscriptJul 15 2020, 5:24 PM

Revision Contents
Changeset List

PathSize
usr.bin/
xinstall/
3 lines

Diff 74430

View Options

usr.bin/xinstall/xinstall.c

Loading...