Page MenuHomeFreeBSD

Allow install(1)'s create_tempfile() to work on Linux hosts
ClosedPublic

Authored by arichardson on Jul 14 2020, 9:25 AM.

Details

Summary

GLibc expects six 'X' characters in the mkstemp template argument

Test Plan

install(1) no longer fails with EINVAL in certain cases

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.

manpage refers to the string and needs to be updated

In D25662#567794, @mjg wrote:

manpage refers to the string and needs to be updated

Good catch! I was not expecting this string to be used in the documentation so I didn't look at the manpage.

I think a better comment would be that glibc requires at least 6 chars, but I don't think it matters.

This revision is now accepted and ready to land.Jul 14 2020, 10:20 AM

Agree @mjg's comment is a slight improvement

Or you could just remove the comment. I can't imagine anyone ever coming along and reducing the number of random characters again.