Page MenuHomeFreeBSD

Remove unused 32-bit compatibility structures from cryptodev.
ClosedPublic

Authored by markj on Jun 26 2020, 2:53 PM.

Details

Summary

The counters are exported by a sysctl and have the same width on all
platforms anyway.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Jun 26 2020, 2:53 PM
markj created this revision.
This revision is now accepted and ready to land.Jun 26 2020, 4:17 PM

Technically timespec32 != timespec for amd64 since i386 uses uint32_t for time_t? However, it seems no one bothered to add the 32-bit compat support shims anyway, so fine to remove.

In D25465#562348, @jhb wrote:

Technically timespec32 != timespec for amd64 since i386 uses uint32_t for time_t? However, it seems no one bothered to add the 32-bit compat support shims anyway, so fine to remove.

Also, cryptotstat should go away with the removal of CRYPTO_TIMING anyway.