Remove unused 32-bit compatibility structures from cryptodev.
ClosedPublic
Actions

Authored by markj on Jun 26 2020, 2:53 PM.

Details

Reviewers

jhb
cem
delphij
jmg

Commits

rG2ed47b49b822: Remove unused 32-bit compatibility structures from cryptodev.
rS362802: Remove unused 32-bit compatibility structures from cryptodev.

Summary

The counters are exported by a sysctl and have the same width on all
platforms anyway.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 26 2020, 2:53 PM

markj created this revision.

Harbormaster completed remote builds in B31974: Diff 73693.Jun 26 2020, 2:53 PM

markj added reviewers: jhb, cem, delphij.Jun 26 2020, 2:54 PM

cem accepted this revision.Jun 26 2020, 4:17 PM

This revision is now accepted and ready to land.Jun 26 2020, 4:17 PM

delphij accepted this revision.Jun 26 2020, 4:21 PM

Technically timespec32 != timespec for amd64 since i386 uses uint32_t for time_t? However, it seems no one bothered to add the 32-bit compat support shims anyway, so fine to remove.

In D25465#562348, @jhb wrote:

Technically timespec32 != timespec for amd64 since i386 uses uint32_t for time_t? However, it seems no one bothered to add the 32-bit compat support shims anyway, so fine to remove.

Also, cryptotstat should go away with the removal of CRYPTO_TIMING anyway.

Closed by commit rS362802: Remove unused 32-bit compatibility structures from cryptodev. (authored by markj). · Explain WhyJun 30 2020, 3:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362802: Remove unused 32-bit compatibility structures from cryptodev..

Herald added a reviewer: jmg. · View Herald TranscriptJun 30 2020, 3:57 PM

Herald added a subscriber: imp. · View Herald Transcript

mjg added a commit: rG2ed47b49b822: Remove unused 32-bit compatibility structures from cryptodev..Sep 16 2021, 11:23 AM