Page MenuHomeFreeBSD

iflib: netmap: honor netmap_irx_irq return values
ClosedPublic

Authored by vmaffione on Jun 6 2020, 11:32 AM.
Tags
None
Referenced Files
F151115215: D25167.id72773.diff
Mon, Apr 6, 4:31 AM
Unknown Object (File)
Sat, Apr 4, 6:20 AM
Unknown Object (File)
Sat, Apr 4, 3:44 AM
Unknown Object (File)
Fri, Apr 3, 6:58 AM
Unknown Object (File)
Sat, Mar 28, 9:31 AM
Unknown Object (File)
Wed, Mar 25, 7:47 AM
Unknown Object (File)
Sun, Mar 22, 12:23 AM
Unknown Object (File)
Sat, Mar 7, 11:28 AM
Subscribers

Details

Summary

In the receive interrupt routine, always call netmap_rx_irq(). The latter function will return != NM_IRQ_PASS if netmap is not active on that specific receive queue, so that the driver can go on with iflib_rxeof(). Note that netmap supports partial opening, where only a subset of the RX or TX rings can be open in netmap mode. Checking the IFCAP_NETMAP flag is not enough to make sure that the queue is indeed in netmap mode.
Moreover, in case netmap_rx_irq() returns NM_IRQ_RESCHED, it means that netmap expects the driver to call netmap_rx_irq() again as soon as possible. Currently, this may happen when the device is attached to a VALE switch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable