Page MenuHomeFreeBSD

iflib: netmap: honor netmap_irx_irq return values
ClosedPublic

Authored by vmaffione on Jun 6 2020, 11:32 AM.
Tags
None
Referenced Files
F144362930: D25167.id72875.diff
Sun, Feb 8, 1:32 AM
Unknown Object (File)
Sat, Feb 7, 4:03 PM
Unknown Object (File)
Sat, Jan 31, 5:20 PM
Unknown Object (File)
Sat, Jan 31, 2:50 AM
Unknown Object (File)
Thu, Jan 29, 8:29 PM
Unknown Object (File)
Thu, Jan 29, 8:29 PM
Unknown Object (File)
Thu, Jan 22, 7:33 PM
Unknown Object (File)
Thu, Jan 22, 7:32 PM
Subscribers

Details

Summary

In the receive interrupt routine, always call netmap_rx_irq(). The latter function will return != NM_IRQ_PASS if netmap is not active on that specific receive queue, so that the driver can go on with iflib_rxeof(). Note that netmap supports partial opening, where only a subset of the RX or TX rings can be open in netmap mode. Checking the IFCAP_NETMAP flag is not enough to make sure that the queue is indeed in netmap mode.
Moreover, in case netmap_rx_irq() returns NM_IRQ_RESCHED, it means that netmap expects the driver to call netmap_rx_irq() again as soon as possible. Currently, this may happen when the device is attached to a VALE switch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable