Page MenuHomeFreeBSD

iflib: netmap: honor netmap_irx_irq return values
ClosedPublic

Authored by vmaffione on Jun 6 2020, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 20, 4:17 PM
Unknown Object (File)
Sep 13 2025, 10:45 PM
Unknown Object (File)
Sep 7 2025, 9:53 PM
Unknown Object (File)
Aug 31 2025, 8:10 PM
Unknown Object (File)
Aug 9 2025, 5:04 AM
Unknown Object (File)
Aug 2 2025, 10:49 PM
Unknown Object (File)
Jul 26 2025, 1:36 PM
Unknown Object (File)
Jul 5 2025, 9:54 PM
Subscribers

Details

Summary

In the receive interrupt routine, always call netmap_rx_irq(). The latter function will return != NM_IRQ_PASS if netmap is not active on that specific receive queue, so that the driver can go on with iflib_rxeof(). Note that netmap supports partial opening, where only a subset of the RX or TX rings can be open in netmap mode. Checking the IFCAP_NETMAP flag is not enough to make sure that the queue is indeed in netmap mode.
Moreover, in case netmap_rx_irq() returns NM_IRQ_RESCHED, it means that netmap expects the driver to call netmap_rx_irq() again as soon as possible. Currently, this may happen when the device is attached to a VALE switch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable