Page MenuHomeFreeBSD

iflib: netmap: honor netmap_irx_irq return values
ClosedPublic

Authored by vmaffione on Jun 6 2020, 11:32 AM.
Tags
None
Referenced Files
F82017191: D25167.diff
Wed, Apr 24, 2:38 PM
Unknown Object (File)
Dec 25 2023, 9:26 PM
Unknown Object (File)
Dec 23 2023, 11:31 AM
Unknown Object (File)
Dec 8 2023, 1:25 AM
Unknown Object (File)
Nov 2 2023, 7:46 AM
Unknown Object (File)
Sep 22 2023, 3:24 PM
Unknown Object (File)
Sep 7 2023, 12:53 PM
Unknown Object (File)
Sep 1 2023, 11:29 PM
Subscribers

Details

Summary

In the receive interrupt routine, always call netmap_rx_irq(). The latter function will return != NM_IRQ_PASS if netmap is not active on that specific receive queue, so that the driver can go on with iflib_rxeof(). Note that netmap supports partial opening, where only a subset of the RX or TX rings can be open in netmap mode. Checking the IFCAP_NETMAP flag is not enough to make sure that the queue is indeed in netmap mode.
Moreover, in case netmap_rx_irq() returns NM_IRQ_RESCHED, it means that netmap expects the driver to call netmap_rx_irq() again as soon as possible. Currently, this may happen when the device is attached to a VALE switch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable