Page MenuHomeFreeBSD

virtio_mmio: Negotiate the upper half of the feature bits too
ClosedPublic

Authored by jrtc27 on Jun 4 2020, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 7:11 AM
Unknown Object (File)
Fri, Jun 21, 5:56 AM
Unknown Object (File)
Thu, Jun 20, 8:40 PM
Unknown Object (File)
Sun, Jun 16, 5:47 PM
Unknown Object (File)
Sun, Jun 16, 3:00 AM
Unknown Object (File)
Sun, Jun 16, 2:07 AM
Unknown Object (File)
Sat, Jun 15, 11:21 PM
Unknown Object (File)
Sat, Jun 15, 11:14 PM
Subscribers

Details

Summary

The feature bits are exposed as a 32-bit register with 2 banks, so we
should negotiate both halves. Notably, VIRTIO_F_VERSION_1 is in the
upper half, and will be used in an upcoming commit.

The PCI bus driver also has this bug, but the legacy BAR layout did not
include selector registers and is rather different from the modern
layout, so it remains solely as legacy.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 31488
Build 29095: arc lint + arc unit