Page MenuHomeFreeBSD

virtio_mmio: Negotiate the upper half of the feature bits too
ClosedPublic

Authored by jrtc27 on Jun 4 2020, 6:35 PM.
Tags
None
Referenced Files
F132189891: D25131.id72841.diff
Tue, Oct 14, 3:10 PM
F132189890: D25131.id.diff
Tue, Oct 14, 3:10 PM
F132189887: D25131.id72676.diff
Tue, Oct 14, 3:10 PM
Unknown Object (File)
Tue, Oct 14, 1:39 AM
Unknown Object (File)
Mon, Oct 6, 6:33 AM
Unknown Object (File)
Fri, Sep 26, 9:51 AM
Unknown Object (File)
Thu, Sep 18, 6:35 PM
Unknown Object (File)
Sep 14 2025, 10:26 PM
Subscribers

Details

Summary

The feature bits are exposed as a 32-bit register with 2 banks, so we
should negotiate both halves. Notably, VIRTIO_F_VERSION_1 is in the
upper half, and will be used in an upcoming commit.

The PCI bus driver also has this bug, but the legacy BAR layout did not
include selector registers and is rather different from the modern
layout, so it remains solely as legacy.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable