Update ipfw(4) manpage with all kernel options
ClosedPublic
Actions

Authored by driesm on Apr 22 2020, 8:22 PM.

Details

Reviewers

bcr
rgrimes
eugen_grosbein.net
melifaro
ae
0mp

Group Reviewers

manpages

Commits

rS361355: Include all currently present kernel options for IPFW

Summary

Include all currently present kernel options for IPFW
Also fix igor complaint about manpage/s/man page

PR: 219075
Reported by: rgrimes@freebsd.org

Test Plan

igor
make install && man 4 ipfw

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

driesm created this revision.Apr 22 2020, 8:22 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 22 2020, 8:22 PM

driesm added a reviewer: eugen_grosbein.net.Apr 22 2020, 8:25 PM

Thank you, nice additions beyond what I stumbled on in the PR

share/man/man4/ipfirewall.4
71	I like .Tn it renders very nice text when your using groff to ps/pdf output. I do not like that .Tn is unsupported by mandoc. People have been removing it from manpages, which I also disagree with, as it should just silently be ignored.

This revision is now accepted and ready to land.Apr 23 2020, 12:25 AM

Ok from manpages. Can't say much about the actual content, though.

FYI, I don't have a bit. We can wait a bit longer though for other people to possibly chime in.

driesm added reviewers: melifaro, ae.Apr 30 2020, 9:11 AM

I think this is fine to commit now :-). If any other pointers come up on the mailing lists regarding this commit I'll make an additional review to tackle those.

I know there well be flak over using .Tn in a man page fix, can you submit a new diff without the .Tn's?

I could definitely do that, @bcr do you think the .Tn is a blocker? Its already present in this man page at line 40.

@0mp: Do you think we should keep the .Tn?
I lean towards committing the change as it is and handle the man page macros in a follow-up commit.

This revision now requires changes to proceed.May 13 2020, 11:41 AM

In D24541#546406, @bcr wrote:

@0mp: Do you think we should keep the .Tn?
I lean towards committing the change as it is and handle the man page macros in a follow-up commit.

I'd keep it for now for consistency and remove all Tn's at once in a subsequent commit.

Hi all, I don't have a commit bit :-). Following the discussion above, could someone take care of the commit? I'll quickly follow up with a new review removing the .Tn's.

I'll commit this today

This revision was not accepted when it landed; it landed in state Needs Revision.May 22 2020, 3:13 AM

Closed by commit rS361355: Include all currently present kernel options for IPFW (authored by rgrimes). · Explain Why

This revision was automatically updated to reflect the committed changes.

rgrimes added a commit: rS361355: Include all currently present kernel options for IPFW.