New driver pchtherm(4), PCH installed thermal sensor.

[takawata]

Summary

This driver is for thermal sensor in Intel PCH chipset.
This exports temperature and some threshold temperature values via sysctl .

[takawata]

Support autoload
Change driver source path.

[driesm]

Nice! Looking forward to this :-).

share/man/man4/pchtherm.4

51

templature/s/temperature

[takawata]

fix man page.
Add files.x86 entry to static configuration.

[val_packett.cool]

Nice. Tested on Kaby Lake-Y (Google Pixelbook, i7-7Y75).

Maybe only spam all the info into dmesg when bootverbose is on? I like cool new dmesg lines but 7 lines for a thermal sensor does seem like a bit too much.

share/man/man4/pchtherm.4

76

missing space "andunder"

sys/dev/intel/pchtherm.c

90

"Haswel" → "Haswell"

173

alart? Alert? (this same mistake/typo is in all the places)

195

"Throtting" → "Throttling"

235

typo "Cucrrent" → "Current"

263

typo "Catastorophic" → "Catastrophic"

[takawata]

Fix typo.
Hide normal informational message under bootverbose.
Add comment on alert register handling.

[danfe]

share/man/man4/pchtherm.4

69

When reached ... will shutdown — sequence of tenses seems wrong here, suggest getting advice from a native speaker. Also, each sentence should start on a new line (after period).

73

Should it be spelled as .Va t0temp?

75

Should it be spelled as .Va t1temp?

78

Missing newline after dot (end of sentence) and space before opening parenthesis.

80

Missing newline after dot (end of sentence) and space before opening parenthesis.

82

Sentence break => new line; should it be spelled as .Va pmtime (as this is a reference to adjacent variable)?

92

Perhaps should be: read-only, do not support...

105

I think you've also spelled your name wrong. :-)

sys/dev/intel/pchtherm.c

74

Should #include block be visually separated with an extra blank line?

101

Local variables are typically separated from the function body with a blank line.

125

Inconsistent vertical spacing in local variables block.

151

Missing space after if and before { (ditto for the line below).

155

Missing space after else.

160

Missing spaces.

168

Superfluous spaces (ditto below).

242

Missing space after | (also below).

267

Missing spaces again here and below.

289

Functions should be visually separated from each other for better readability.

296

Ditto (and below).

[takawata]

Fix man pages wording.
Source coude style fix.

[danfe]

@takawata wrote:

Source coude style fix.

Thanks. Couple of style bugs are still there (search for if( without the space), but I don't want to cherry pick each particular case and just leave it at your discretion.

[avg]

In D24077#530114, @takawata wrote:

fix man page.
Add files.x86 entry to static configuration.

It seems that you never actually added the files.x86 change.
At least, I do not see it.