Page MenuHomeFreeBSD
Differential D24026

www/chromium: Fix aarch64 by reapplying r527876
ClosedPublic
Actions

Authored by cem on Mar 11 2020, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 7:43 AM
Unknown Object (File)
Thu, Jan 16, 8:26 AM
Unknown Object (File)
Thu, Jan 16, 1:47 AM
Unknown Object (File)
Wed, Jan 15, 9:47 PM
Unknown Object (File)
Wed, Jan 1, 12:24 AM
Unknown Object (File)
Dec 2 2024, 8:28 PM
Unknown Object (File)
Oct 18 2024, 2:15 PM
Unknown Object (File)
Oct 9 2024, 2:28 PM
View All 48 Files
Subscribers
andrew
emaste
mat

Details

Reviewers
mikael
rene
jrm
cmt
manu
Commits
rP528250: www/chromium: Fix aarch64 by reapplying r527876
Summary

It was lost in the 80.x update, unfortunately. Mea culpa.

Test Plan

I don't have any way to build-test this for aarch64, looking for help.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29880
Build 27700: arc lint + arc unit

Event Timeline

cem created this revision.Mar 11 2020, 4:22 PM
Herald added subscribers: mat, emaste, andrew. · View Herald TranscriptMar 11 2020, 4:22 PM
Harbormaster completed remote builds in B29880: Diff 69395.Mar 11 2020, 4:22 PM
jrm added a comment.Mar 11 2020, 4:26 PM

Since this will change the package, PORTREVISION should be bumped.

mikael added a comment.Mar 11 2020, 4:36 PM
In D24026#528366, @jrm wrote:

Since this will change the package, PORTREVISION should be bumped.

It's a tier2 arch and affects only head, no need to bump it.

jrm added a comment.Mar 11 2020, 4:41 PM

You're right. I didn't notice that the first two files were specific to aarch64/arm64 and the changes in the third file are protected by #defined(ARMV8_OS_.... Sorry for the noise.

mikael accepted this revision.Mar 11 2020, 7:25 PM

LGTM, thanks for the quick patch.

This revision is now accepted and ready to land.Mar 11 2020, 7:25 PM
Closed by commit rP528250: www/chromium: Fix aarch64 by reapplying r527876 (authored by cem). · Explain WhyMar 11 2020, 8:00 PM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rP528250: www/chromium: Fix aarch64 by reapplying r527876.

Revision Contents
Changeset List

Diff 69395

View Options

www/chromium/files/patch-third__party_boringssl_src_crypto_cpu-aarch64-linux.c

Loading...
View Options

www/chromium/files/patch-third__party_crc32c_src_src_crc32c__arm64__linux__check.h

Loading...
View Options

www/chromium/files/patch-third__party_zlib_arm__features.c

Loading...