Paths

Table of Contentst

Differential D22967

vmx: fix initialization of TSO related descriptor fields
ClosedPublic
Actions

Authored by vmaffione on Dec 30 2019, 10:08 AM.

Tags

None

Referenced Files

	F103130036: D22967.diff
	Thu, Nov 21, 9:49 AM

	Unknown Object (File)
	Fri, Nov 15, 7:41 AM

	Unknown Object (File)
	Tue, Oct 29, 11:37 PM

	Unknown Object (File)
	Oct 1 2024, 9:42 AM

	Unknown Object (File)
	Sep 30 2024, 9:46 PM

	Unknown Object (File)
	Sep 22 2024, 11:39 AM

	Unknown Object (File)
	Sep 18 2024, 1:21 PM

	Unknown Object (File)
	Sep 18 2024, 1:07 AM

View All 72 Files

Subscribers

Details

Reviewers

pkelsey
marius
mmacy
avg
bryanv
rstone
shurd

Commits

rS356932: MFC r356703
rS356703: vmx: fix initialization of TSO related descriptor fields

Summary

Fix a mistake introduced by r343291, which ported the vmx(4) driver to iflib.
In case of TSO, the hlen field of the (first) tx descriptor must be initialized to the cumulative length of Ethernet, IP and TCP headers. The length of the TCP header was missing.

Reported by: pkelsey

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vmaffione created this revision.Dec 30 2019, 10:08 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 30 2019, 10:08 AM

Harbormaster completed remote builds in B28377: Diff 66134.Dec 30 2019, 10:08 AM

vmaffione added reviewers: mmacy, avg, bryanv, rstone, shurd.Jan 12 2020, 8:56 AM

LGTM.
This change has been tested by Panzura.

This revision is now accepted and ready to land.Jan 12 2020, 7:47 PM

Closed by commit rS356703: vmx: fix initialization of TSO related descriptor fields (authored by vmaffione). · Explain WhyJan 13 2020, 9:26 PM

This revision was automatically updated to reflect the committed changes.

vmaffione added a commit: rS356703: vmx: fix initialization of TSO related descriptor fields.

vmaffione added a commit: rS356932: MFC r356703.Jan 20 2020, 10:15 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

vmware/

vmxnet3/

2 lines

Diff 66703

head/sys/dev/vmware/vmxnet3/if_vmx.c

Loading...