Page MenuHomeFreeBSD

netinet*: replace IP6_EXTHDR_GET()
ClosedPublic

Authored by bz on Nov 12 2019, 6:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 11:07 AM
Unknown Object (File)
Wed, Oct 22, 11:07 AM
Unknown Object (File)
Wed, Oct 22, 11:07 AM
Unknown Object (File)
Tue, Oct 21, 10:20 PM
Unknown Object (File)
Thu, Oct 16, 10:33 AM
Unknown Object (File)
Sep 13 2025, 7:34 PM
Unknown Object (File)
Sep 13 2025, 5:20 AM
Unknown Object (File)
Sep 12 2025, 11:35 PM
Subscribers

Details

Summary

In a few places we have IP6_EXTHDR_GET() left in upper layer protocols.
The IP6_EXTHDR_GET() macro might perform an m_pulldown() in case the data
fragment is not contiguous.

Convert these last remaining instances into m_pullup()s instead.
In CARP, for example, we will a few lines later call m_pullup() anyway,
the IPsec code coming from OpenBSD would otherwise have done the m_pullup()
and are copying the data a bit later anyway, so pulling it in seems no
better or worse.

Note: this leaves very few m_pulldown() cases behind in the tree and we
might want to consider removing them as well to make mbuf management
easier again on a path to variable size mbufs, especially given
m_pulldown() still has an issue not re-checking M_WRITEABLE().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable