Paths

Table of Contentst

Differential D21947

gcore: Add aarch64 32-bit core support
ClosedPublic
Actions

Authored by jhibbits on Oct 8 2019, 9:30 PM.

Tags

None

Referenced Files

	F83182627: D21947.id63089.diff
	Tue, May 7, 10:09 AM

	Unknown Object (File)
	Wed, May 1, 5:56 AM

	Unknown Object (File)
	Sat, Apr 27, 7:24 AM

	Unknown Object (File)
	Sat, Apr 27, 1:15 AM

	Unknown Object (File)
	Sat, Apr 27, 1:15 AM

	Unknown Object (File)
	Sat, Apr 27, 1:15 AM

	Unknown Object (File)
	Sat, Apr 27, 1:15 AM

	Unknown Object (File)
	Sat, Apr 27, 1:15 AM

View All 27 Files

Subscribers

Details

Reviewers

manu
andrew

Group Reviewers

Commits

rS353436: gcore: Add aarch64 32-bit core support

Summary

Add trivial 32-bit arm cores on aarch64 support for gcore. This doesn't handle fpregs.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 26953
Build 25255: arc lint + arc unit

Event Timeline

jhibbits created this revision.Oct 8 2019, 9:30 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 8 2019, 9:30 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B26936: Diff 63057.Oct 8 2019, 9:30 PM

stevek added a subscriber: stevek.Oct 8 2019, 9:32 PM

jhibbits retitled this revision from gcore: Add aarch64 support to gcore: Add aarch64 32-bit core support.Oct 8 2019, 9:33 PM

jhibbits edited the summary of this revision. (Show Details)

andrew added inline comments.Oct 9 2019, 8:42 AM

usr.bin/gcore/elf32core.c
40	I think you want to use `rs->x[13]` here. The comment in `fill_regs32` in `sys/arm64/arm64/machdep.c` is useful: `/* For arm32, SP is r13 and LR is r14 */` You probably also want to set `r_lr` to `rs->x14`.

Address andrew's feedback. Thanks!

Harbormaster completed remote builds in B26953: Diff 63082.Oct 9 2019, 3:43 PM

emaste added inline comments.Oct 9 2019, 4:46 PM

usr.bin/gcore/Makefile
8	my usual pedantic comment, keep these sorts of additions in alpha order :)
usr.bin/gcore/elf32core.c
55	fwiw we've used ARM64TODO in the past

Address @emaste's comments

Harbormaster completed remote builds in B26958: Diff 63089.Oct 9 2019, 5:26 PM

bdragon mentioned this in D21954: gcore: Add powerpc64 32-bit gcore support.Oct 11 2019, 1:59 AM

andrew accepted this revision.Oct 11 2019, 7:27 AM

This revision is now accepted and ready to land.Oct 11 2019, 7:27 AM

Closed by commit rS353436: gcore: Add aarch64 32-bit core support (authored by jhibbits). · Explain WhyOct 11 2019, 2:16 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS353436: gcore: Add aarch64 32-bit core support.

Herald added a subscriber: imp. · View Herald TranscriptOct 11 2019, 2:16 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

4 lines

usr.bin/

gcore/

2 lines

12 lines

Diff 63082

sys/arm64/include/elf.h

Loading...

usr.bin/gcore/Makefile

Loading...

usr.bin/gcore/elf32core.c

Loading...