Differential D21931

Add WC support for arm64 in the ENA driver
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 8 2019, 7:21 AM.

Details

Reviewers

cperciva
mw

Commits

rS354218: Add WC support for arm64 in the ENA driver

Summary

As the pmamp_change_attr() is public on arm64 since D20787, it can be
used on the arm64 to map memory range as with the write combined
attribute.

It requires the driver to use generic VM_MEMATTR_WRITE_COMBINING flag
instead of the x86 specific PAT_WRITE_COMBINING.

Submitted by: Michal Krawczyk <mk@semihalf.com>
Obtained from: Semihalf
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mk_semihalf.com created this revision.Oct 8 2019, 7:21 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2019, 7:21 AM

mk_semihalf.com added a child revision: D21932: Fix ENA keep alive timeout due to prolonged reset.Oct 8 2019, 7:26 AM

The pmap_change_attr() API is private on arm64

It hasn't been private since D20787 landed! (Was required for GPU drivers.)

Due to pmap_change_attr() being public on arm64, the patch was reworked to use it instead

mk_semihalf.com added a parent revision: D22055: Fix pmap_change_attr() on arm64 to allow KV addresses.Oct 16 2019, 11:24 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 3:38 PM

Closed by commit rS354218: Add WC support for arm64 in the ENA driver (authored by mw). · Explain Why

This revision was automatically updated to reflect the committed changes.

mw added a commit: rS354218: Add WC support for arm64 in the ENA driver.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ena/

ena.c

12 lines

Diff 63351

View Options

Add WC support for arm64 in the ENA driverClosedPublicActions