Page MenuHomeFreeBSD
Differential D21931

Add WC support for arm64 in the ENA driver
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 8 2019, 7:21 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Apr 6, 7:53 PM
Unknown Object (File)
Sat, Apr 6, 2:56 PM
Unknown Object (File)
Sat, Apr 6, 2:28 PM
Unknown Object (File)
Sat, Apr 6, 2:16 PM
Unknown Object (File)
Feb 18 2024, 7:22 AM
Unknown Object (File)
Dec 26 2023, 3:38 AM
Unknown Object (File)
Dec 20 2023, 5:07 AM
Unknown Object (File)
Dec 17 2023, 6:38 PM
View All 39 Files
Subscribers
gtzalik_amazon.com
idose_amazon.com
imp
val_packett.cool

Details

Reviewers
cperciva
mw
Commits
rS354218: Add WC support for arm64 in the ENA driver
Summary

As the pmamp_change_attr() is public on arm64 since D20787, it can be
used on the arm64 to map memory range as with the write combined
attribute.

It requires the driver to use generic VM_MEMATTR_WRITE_COMBINING flag
instead of the x86 specific PAT_WRITE_COMBINING.

Submitted by: Michal Krawczyk <mk@semihalf.com>
Obtained from: Semihalf
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mk_semihalf.com created this revision.Oct 8 2019, 7:21 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 8 2019, 7:21 AM
mk_semihalf.com added a child revision: D21932: Fix ENA keep alive timeout due to prolonged reset.Oct 8 2019, 7:26 AM
val_packett.cool added a subscriber: val_packett.cool.EditedOct 9 2019, 12:14 PM

The pmap_change_attr() API is private on arm64

It hasn't been private since D20787 landed! (Was required for GPU drivers.)

mk_semihalf.com updated this revision to Diff 63351.Oct 16 2019, 11:24 AM
mk_semihalf.com edited the summary of this revision. (Show Details)

Due to pmap_change_attr() being public on arm64, the patch was reworked to use it instead

mk_semihalf.com added a parent revision: D22055: Fix pmap_change_attr() on arm64 to allow KV addresses.Oct 16 2019, 11:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 3:38 PM
Closed by commit rS354218: Add WC support for arm64 in the ENA driver (authored by mw). · Explain Why
This revision was automatically updated to reflect the committed changes.
mw added a commit: rS354218: Add WC support for arm64 in the ENA driver.

Revision Contents
Changeset List

PathSize
sys/
dev/
ena/
28 lines

Diff 63024

View Options

sys/dev/ena/ena.c

Loading...