Page MenuHomeFreeBSD

Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver
ClosedPublic

Authored by rajesh1.kumar_amd.com on Aug 29 2019, 4:07 AM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Added ntb_hw_amd.4 as a new file only. But somehow it's compared with ntb_transport.4. Any way I can resolve it?

bcr added a subscriber: bcr.Aug 29 2019, 8:39 AM

Can you run textproc/igor and "mandoc -Tlint" over the new man page and fix what they tell you?
I saw a couple of instances where there need to be line breaks after a sentence stop. Thank you.

Made the changes to fix the issues reported by igor and mandoc. Also corrected a
typo and mode related information in CONFIGURATION section

Thanks @bcr . I used arc diff to create the revisions. But somehow it's comparing ntb_hw_amd with ntb_transport always. Let me know if I can do something different to have that fixed.

bcr accepted this revision.Aug 29 2019, 11:26 AM

Looks good to me now. Thank you!

This revision is now accepted and ready to land.Aug 29 2019, 11:26 AM
mav accepted this revision.Aug 29 2019, 1:43 PM

I'll tune few minor things, like copyright year in the future, but otherwise it looks good.

This revision was automatically updated to reflect the committed changes.