Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Added ntb_hw_amd.4 as a new file only. But somehow it's compared with ntb_transport.4. Any way I can resolve it?
Can you run textproc/igor and "mandoc -Tlint" over the new man page and fix what they tell you?
I saw a couple of instances where there need to be line breaks after a sentence stop. Thank you.
Made the changes to fix the issues reported by igor and mandoc. Also corrected a
typo and mode related information in CONFIGURATION section
Thanks @bcr . I used arc diff to create the revisions. But somehow it's comparing ntb_hw_amd with ntb_transport always. Let me know if I can do something different to have that fixed.
I'll tune few minor things, like copyright year in the future, but otherwise it looks good.
But somehow it's comparing ntb_hw_amd with ntb_transport always.
I think this is an artifact of git's copy/rename detection, and if that's the case there's some environment variable or cmd line option to disable it. I'll try to take a look for it and update the code review wiki page.