Page MenuHomeFreeBSD

Manpage for AMD Non-Transparent Bridge (ntb_hw_amd) driver
ClosedPublic

Authored by rajesh1.kumar_amd.com on Aug 29 2019, 4:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 3:03 AM
Unknown Object (File)
Feb 22 2024, 5:26 PM
Unknown Object (File)
Feb 14 2024, 12:34 AM
Unknown Object (File)
Feb 14 2024, 12:33 AM
Unknown Object (File)
Dec 27 2023, 7:10 AM
Unknown Object (File)
Dec 20 2023, 7:08 AM
Unknown Object (File)
Dec 12 2023, 9:42 PM
Unknown Object (File)
Nov 11 2023, 12:12 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Added ntb_hw_amd.4 as a new file only. But somehow it's compared with ntb_transport.4. Any way I can resolve it?

Can you run textproc/igor and "mandoc -Tlint" over the new man page and fix what they tell you?
I saw a couple of instances where there need to be line breaks after a sentence stop. Thank you.

Made the changes to fix the issues reported by igor and mandoc. Also corrected a
typo and mode related information in CONFIGURATION section

Thanks @bcr . I used arc diff to create the revisions. But somehow it's comparing ntb_hw_amd with ntb_transport always. Let me know if I can do something different to have that fixed.

Looks good to me now. Thank you!

This revision is now accepted and ready to land.Aug 29 2019, 11:26 AM

I'll tune few minor things, like copyright year in the future, but otherwise it looks good.

But somehow it's comparing ntb_hw_amd with ntb_transport always.

I think this is an artifact of git's copy/rename detection, and if that's the case there's some environment variable or cmd line option to disable it. I'll try to take a look for it and update the code review wiki page.

But somehow it's comparing ntb_hw_amd with ntb_transport always.

I think this is an artifact of git's copy/rename detection, and if that's the case there's some environment variable or cmd line option to disable it. I'll try to take a look for it and update the code review wiki page.

Thanks for looking at it @emaste