Implement MDIO mux with Broadcom NS2 PCIe PHY initialization

[kd]

Summary

NS2 uses a PCIe PHY which is configured over MDIO.
Configure reference clock amplitude on PHY init.

[andrew]

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c

47

This should be #define<tab>

188

The comment should start on the second line, i.e.

/*
 * start_...

210

ret is not a boolean type so this should be if (ret != 0)

211

Why goto err; when it just returns? This is normally used when you need to perform a clean up.

226–227

And here.

247

Missing newline.

head/sys/conf/files.arm64

179–181

These should have a more specific option to enable them, e.g. optional brcmmdio fdt

[emaste]

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c

4

Aside, All rights reserved. has been removed from the standard FreeBSD copyright templates; of course it can stay if required by your client, but if it's only here because it was copied from an existing file it could be removed.

[ehem_freebsd_m5p.com]

I ended up looking at two of the files which originated from D21335. These spots appear unused and it is in my queue for getting these hunks removed (followed by further cleanup of the files related to D48449).

head/sys/arm64/broadcom/brcmmdio/mdio_nexus_iproc.c

95–96

I haven't found any references to this anywhere. Was this a precursor to what turned into brcm_mdionexus_driver?

head/sys/arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c

69–70

Similar to the above. Here it appears ns2_pcie_phy_driver is actually used whereas this appears a leftover from development.