Paths

Table of Contentst

Differential D21335

Implement MDIO mux with Broadcom NS2 PCIe PHY initialization
ClosedPublic
Actions

Authored by kd on Aug 20 2019, 7:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 4:41 PM

	Unknown Object (File)
	Dec 25 2024, 6:50 AM

	Unknown Object (File)
	Dec 17 2024, 9:19 AM

	Unknown Object (File)
	Nov 5 2024, 1:03 PM

	Unknown Object (File)
	Nov 1 2024, 2:54 PM

	Unknown Object (File)
	Oct 18 2024, 11:14 PM

	Unknown Object (File)
	Oct 18 2024, 11:14 PM

	Unknown Object (File)
	Oct 18 2024, 11:13 PM

View All 59 Files

Subscribers

Details

Reviewers

wma
mw
manu

Commits

rS359647: Add MDIO PHY driver for NS2 ARM64 platform.

Summary

NS2 uses a PCIe PHY which is configured over MDIO.
Configure reference clock amplitude on PHY init.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kd created this revision.Aug 20 2019, 7:39 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 20 2019, 7:39 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

wma accepted this revision.Apr 6 2020, 4:15 AM

This revision is now accepted and ready to land.Apr 6 2020, 4:15 AM

Closed by commit rS359647: Add MDIO PHY driver for NS2 ARM64 platform. (authored by wma). · Explain WhyApr 6 2020, 5:49 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rS359647: Add MDIO PHY driver for NS2 ARM64 platform..

andrew added inline comments.Apr 6 2020, 7:12 AM

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c
47	This should be `#define<tab>`
188	The comment should start on the second line, i.e. /* * start_...
210	`ret` is not a boolean type so this should be `if (ret != 0)`
211	Why `goto err;` when it just returns? This is normally used when you need to perform a clean up.
226–227	And here.
247	Missing newline.
head/sys/conf/files.arm64
179–181	These should have a more specific option to enable them, e.g. `optional brcmmdio fdt`

emaste added inline comments.Apr 6 2020, 5:59 PM

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c
4	Aside, `All rights reserved.` has been removed from the standard FreeBSD copyright templates; of course it can stay if required by your client, but if it's only here because it was copied from an existing file it could be removed.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

broadcom/

brcmmdio/

mdio_mux_iproc.c

399 lines

mdio_nexus_iproc.c

234 lines

mdio_ns2_pcie_phy.c

162 lines

conf/

3 lines

dev/

mdio/

32 lines

Diff 70242

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c

Loading...

head/sys/arm64/broadcom/brcmmdio/mdio_nexus_iproc.c

Loading...

head/sys/arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c

Loading...

head/sys/conf/files.arm64

Loading...

head/sys/dev/mdio/mdio_if.m

Loading...