Page MenuHomeFreeBSD

Implement MDIO mux with Broadcom NS2 PCIe PHY initialization
ClosedPublic

Authored by kd on Aug 20 2019, 7:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 8:40 PM
Unknown Object (File)
Thu, Sep 25, 9:08 PM
Unknown Object (File)
Tue, Sep 16, 6:24 PM
Unknown Object (File)
Jul 22 2025, 7:11 PM
Unknown Object (File)
Jul 22 2025, 10:07 AM
Unknown Object (File)
Jun 19 2025, 1:35 PM
Unknown Object (File)
Jun 15 2025, 3:00 PM
Unknown Object (File)
Jun 13 2025, 8:28 PM
Subscribers

Details

Summary

NS2 uses a PCIe PHY which is configured over MDIO.
Configure reference clock amplitude on PHY init.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 6 2020, 4:15 AM
This revision was automatically updated to reflect the committed changes.
head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c
47

This should be #define<tab>

188

The comment should start on the second line, i.e.

/*
 * start_...
210

ret is not a boolean type so this should be if (ret != 0)

211

Why goto err; when it just returns? This is normally used when you need to perform a clean up.

226–227

And here.

247

Missing newline.

head/sys/conf/files.arm64
179–181

These should have a more specific option to enable them, e.g. optional brcmmdio fdt

head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c
4

Aside, All rights reserved. has been removed from the standard FreeBSD copyright templates; of course it can stay if required by your client, but if it's only here because it was copied from an existing file it could be removed.