NS2 uses a PCIe PHY which is configured over MDIO.
Configure reference clock amplitude on PHY init.
Details
Details
- Reviewers
wma mw manu - Commits
- rS359647: Add MDIO PHY driver for NS2 ARM64 platform.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c | ||
|---|---|---|
| 47 ↗ | (On Diff #70242) | This should be #define<tab> |
| 188 ↗ | (On Diff #70242) | The comment should start on the second line, i.e. /* * start_... |
| 210 ↗ | (On Diff #70242) | ret is not a boolean type so this should be if (ret != 0) |
| 211 ↗ | (On Diff #70242) | Why goto err; when it just returns? This is normally used when you need to perform a clean up. |
| 226–227 ↗ | (On Diff #70242) | And here. |
| 247 ↗ | (On Diff #70242) | Missing newline. |
| head/sys/conf/files.arm64 | ||
| 179–181 ↗ | (On Diff #70242) | These should have a more specific option to enable them, e.g. optional brcmmdio fdt |
| head/sys/arm64/broadcom/brcmmdio/mdio_mux_iproc.c | ||
|---|---|---|
| 4 ↗ | (On Diff #70242) | Aside, All rights reserved. has been removed from the standard FreeBSD copyright templates; of course it can stay if required by your client, but if it's only here because it was copied from an existing file it could be removed. |