Page MenuHomeFreeBSD

Simplify handling of superpages in pmap_clear_modify()
ClosedPublic

Authored by alc on Jul 22 2019, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 10:07 PM
Unknown Object (File)
Jan 14 2024, 5:39 AM
Unknown Object (File)
Dec 20 2023, 6:21 AM
Unknown Object (File)
Dec 19 2023, 12:53 PM
Unknown Object (File)
Nov 25 2023, 5:50 AM
Unknown Object (File)
Nov 22 2023, 9:09 AM
Unknown Object (File)
Nov 22 2023, 8:54 AM
Unknown Object (File)
Nov 13 2023, 8:42 AM

Details

Summary

If a demotion succeeds, then all of the 4KB page mappings within the superpage-sized region must be valid, so there is no point in testing the validity of the 4KB page mapping that is going to be write protected.

Deindent the code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Peter, could you please test this patch on amd64 and i386.

I finished the full stress2 tests on amd64 without any issues.

On i386 I ran into this problem, which seems unrelated to me. Unfortunately I did not get a dump as the debugger was looping.
I made a short attempt to recreate the problem, but without any luck.
Here's the partial console log: https://people.freebsd.org/~pho/stress/log/alc010.txt
I still need to run 170 tests on i386 to complete a full test.

In D21027#456866, @pho wrote:

I finished the full stress2 tests on amd64 without any issues.

Thank you.

On i386 I ran into this problem, which seems unrelated to me. Unfortunately I did not get a dump as the debugger was looping.
I made a short attempt to recreate the problem, but without any luck.
Here's the partial console log: https://people.freebsd.org/~pho/stress/log/alc010.txt
I still need to run 170 tests on i386 to complete a full test.

I agree that that problem seems unrelated.

The i386 tests finished with one further problem and an incomplete report: https://people.freebsd.org/~pho/stress/log/alc011.txt

In D21027#457081, @pho wrote:

The i386 tests finished with one further problem and an incomplete report: https://people.freebsd.org/~pho/stress/log/alc011.txt

That also seems unrelated. Thanks.

This revision is now accepted and ready to land.Jul 25 2019, 7:26 AM

hi,
I stopped by this code review while I was troubleshooting things for PR 242137.

as far as we understood, the issue I reported on that bug happens only if I use a particular hardware, but others may also be affected (not sure though).

should some of you guys can drop a quick look on that PR would be awesome; I'm pretty much interested on getting a better picture of all that.

hi,
I stopped by this code review while I was troubleshooting things for PR 242137.

as far as we understood, the issue I reported on that bug happens only if I use a particular hardware, but others may also be affected (not sure though).

should some of you guys can drop a quick look on that PR would be awesome; I'm pretty much interested on getting a better picture of all that.

The thread in that PR is quite long and hard to understand. Can you provide a brief summary? From comment 126 it sounds like you are able to trigger some ntpd problem when both r352517 and r352519 are applied, but not when either commit is reverted?