Differential D19967

Don't overwrite buffer when computing checksum via IPV6_CHECKSUM
ClosedPublic
Actions

Authored by tuexen on Apr 19 2019, 4:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 10, 9:00 PM

	Unknown Object (File)
	Thu, Dec 5, 7:25 PM

	Unknown Object (File)
	Oct 29 2024, 5:14 AM

	Unknown Object (File)
	Oct 11 2024, 2:42 PM

	Unknown Object (File)
	Sep 30 2024, 1:46 AM

	Unknown Object (File)
	Sep 17 2024, 4:14 PM

	Unknown Object (File)
	Sep 5 2024, 3:34 PM

	Unknown Object (File)
	Sep 1 2024, 2:28 PM

View All 39 Files

Subscribers

imp

Details

Reviewers

bz
jtl
emaste
thj

Commits

rS346401: Avoid a buffer overwrite in rip6_output() when computing the checksum

Summary

When computing the checksum for a packet to be sent, ensure you have enough bytes in the packet to write the checksum. The existing check was wrong (off by one error) and would result in writing one byte after the packet buffer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23767

Event Timeline

tuexen created this revision.Apr 19 2019, 4:36 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 19 2019, 4:36 PM

Harbormaster completed remote builds in B23767: Diff 56386.Apr 19 2019, 4:36 PM

Can you please improve the description before committing stating that it's related to rip6_output().

This revision is now accepted and ready to land.Apr 19 2019, 4:58 PM

Closed by commit rS346401: Avoid a buffer overwrite in rip6_output() when computing the checksum (authored by tuexen). · Explain WhyApr 19 2019, 5:21 PM

This revision was automatically updated to reflect the committed changes.

In D19967#429234, @bz wrote:

Can you please improve the description before committing stating that it's related to rip6_output().

Done.

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

raw_ip6.c

2 lines

Diff 56386

View Options

Don't overwrite buffer when computing checksum via IPV6_CHECKSUMClosedPublicActions