Page MenuHomeFreeBSD

Don't overwrite buffer when computing checksum via IPV6_CHECKSUM
ClosedPublic

Authored by tuexen on Apr 19 2019, 4:36 PM.

Details

Summary

When computing the checksum for a packet to be sent, ensure you have enough bytes in the packet to write the checksum. The existing check was wrong (off by one error) and would result in writing one byte after the packet buffer.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tuexen created this revision.Apr 19 2019, 4:36 PM
bz accepted this revision.Apr 19 2019, 4:58 PM

Can you please improve the description before committing stating that it's related to rip6_output().

This revision is now accepted and ready to land.Apr 19 2019, 4:58 PM
This revision was automatically updated to reflect the committed changes.
In D19967#429234, @bz wrote:

Can you please improve the description before committing stating that it's related to rip6_output().

Done.