Page MenuHomeFreeBSD

Fix bhyve PCIe capability emulation
ClosedPublic

Authored by chuck on Thu, Mar 14, 9:55 AM.

Details

Summary

PCIe devices starting with version 1.1 must set the Role-Based Error
Reporting bit.

And while we're in the neighborhood, generalize the code assigning the
device type.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chuck created this revision.Thu, Mar 14, 9:55 AM
chuck updated this revision to Diff 55051.Thu, Mar 14, 10:11 AM

added wrong diff

rgrimes accepted this revision as: rgrimes.Thu, Mar 14, 11:38 AM
This revision is now accepted and ready to land.Thu, Mar 14, 11:38 AM
imp accepted this revision.Thu, Mar 14, 11:19 PM
imp added inline comments.
usr.sbin/bhyve/pci_emul.c
956 ↗(On Diff #55051)

this is a nop, but likely a good change none-the-less if you intended to do it.

araujo accepted this revision.Fri, Mar 15, 12:11 AM

LGTM!

chuck added inline comments.Fri, Mar 15, 12:47 AM
usr.sbin/bhyve/pci_emul.c
956 ↗(On Diff #55051)

Yes, I have a WIP patch to add endpoint support which then would use type.

This revision was automatically updated to reflect the committed changes.