Differential D19175

ix: Fix accessing wrong register
ClosedPublic
Actions

Authored by piotr.pietruszewski_intel.com on Feb 13 2019, 9:45 AM.

Details

Reviewers

erj
pkubaj

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG73fa89e041ff: ix: Fix accessing wrong register

Summary

Use IXGBE_GRC_BY_MAC(hw) macro instead of IXGBE_GRC as IXGBE_GRC's
address is different on Denverton platform.

This patch is part of change made in NetBSD kernel
by Masanobu Saitoh, NetBSD maintainer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

piotr.pietruszewski_intel.com created this revision.Feb 13 2019, 9:45 AM

Herald added a subscriber: ae. · View Herald TranscriptFeb 13 2019, 9:45 AM

Harbormaster completed remote builds in B22477: Diff 53867.Feb 13 2019, 9:45 AM

piotr.pietruszewski_intel.com added a reviewer: Intel Networking.Feb 13 2019, 9:49 AM

erj accepted this revision as: erj.Feb 21 2019, 7:09 PM

Looks OK, the specific commit is http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/pci/ixgbe/ixgbe.c?rev=1.166&content-type=text/x-cvsweb-markup&only_with_tag=MAIN.

This revision is now accepted and ready to land.Aug 10 2023, 12:59 PM

Closed by commit rG73fa89e041ff: ix: Fix accessing wrong register (authored by piotr.pietruszewski_intel.com, committed by pkubaj). · Explain WhyAug 10 2023, 1:45 PM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rG73fa89e041ff: ix: Fix accessing wrong register.

Owners added a reviewer: Restricted Owners Package.Aug 10 2023, 1:45 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 1:45 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

if_ix.c

4 lines

Diff 125805

View Options

ix: Fix accessing wrong registerClosedPublicActions