Page MenuHomeFreeBSD
Differential D19054

readelf: decode FreeBSD note types
ClosedPublic
Actions

Authored by emaste on Feb 1 2019, 3:11 PM.
Tags
None
Referenced Files
F83146844: D19054.diff
Mon, May 6, 11:19 PM
Unknown Object (File)
Fri, May 3, 10:29 PM
Unknown Object (File)
Tue, Apr 30, 5:34 AM
Unknown Object (File)
Tue, Apr 30, 5:34 AM
Unknown Object (File)
Tue, Apr 30, 5:34 AM
Unknown Object (File)
Tue, Apr 30, 5:00 AM
Unknown Object (File)
Tue, Apr 30, 5:00 AM
Unknown Object (File)
Mon, Apr 29, 10:00 PM
View All 55 Files
Subscribers
brooks
imp
kib

Details

Reviewers
kaiw
jkoshy_users.sourceforge.net
markj
brooks
kib
Commits
rS343669: readelf: decode FreeBSD note types
Summary

Sample output:

% usr.bin/readelf/obj/readelf -n a.out.modified

Notes at offset 0x00000288 with length 0x00000048:
  Owner         Data size       Description
  FreeBSD       0x00000004      NT_FREEBSD_ABI_TAG
   ABI tag: 1300005
  FreeBSD       0x00000004      NT_FREEBSD_FEATURE_CTL
   Features: ASLR_DISABLE
  FreeBSD       0x00000004      NT_FREEBSD_NOINIT_TAG
   description data: 00 00 00 00

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Feb 1 2019, 3:11 PM
emaste added a parent revision: D19053: readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding.
brooks accepted this revision.Feb 1 2019, 6:15 PM

LGTM

contrib/elftoolchain/readelf/readelf.c
3494 ↗(On Diff #53510)

Is it local style to declare this sort of thing nearby? style(9) would be it above all the functions.

This revision is now accepted and ready to land.Feb 1 2019, 6:15 PM
kib accepted this revision.Feb 1 2019, 6:44 PM
emaste added inline comments.Feb 1 2019, 8:24 PM
contrib/elftoolchain/readelf/readelf.c
3494 ↗(On Diff #53510)

They seem to be distributed in the existing file; probably they should actually be split out into a notes.c file but I would do that upstream to avoid conflicts

emaste updated this revision to Diff 53525.Feb 1 2019, 9:57 PM

add alignment check

This revision now requires review to proceed.Feb 1 2019, 9:57 PM
emaste updated this revision to Diff 53526.Feb 1 2019, 10:00 PM

actually check alignment

kib added inline comments.Feb 1 2019, 10:13 PM
contrib/elftoolchain/readelf/readelf.c
3504 ↗(On Diff #53526)

May be print something explaining why the note is not decoded.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2019, 10:24 PM
Closed by commit rS343669: readelf: decode FreeBSD note types (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2019, 10:24 PM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
readelf/
55 lines

Diff 53527

View Options

head/contrib/elftoolchain/readelf/readelf.c

Loading...