Page MenuHomeFreeBSD

readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding
ClosedPublic

Authored by emaste on Feb 1 2019, 3:09 PM.

Details

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Feb 1 2019, 3:09 PM
brooks accepted this revision.Feb 1 2019, 6:18 PM
brooks added a subscriber: brooks.

LGTM

contrib/elftoolchain/readelf/readelf.c
2741 ↗(On Diff #53509)

Would this make more sense to the user as something like:

printf(" unknown(0x%jx)", (uintmax_t)val);
This revision is now accepted and ready to land.Feb 1 2019, 6:18 PM
kib added a subscriber: kib.Feb 1 2019, 6:44 PM
kib added inline comments.
contrib/elftoolchain/readelf/readelf.c
2736 ↗(On Diff #53509)

This is weird, why not do &= ~ ?

2741 ↗(On Diff #53509)

It would make more sense to print each unknown flag individually. At least I do find it more useful, from my experience with the Intel CPUID bits and DMAR capabilities reports.

This revision was automatically updated to reflect the committed changes.
emaste added inline comments.Feb 1 2019, 8:30 PM
contrib/elftoolchain/readelf/readelf.c
2741 ↗(On Diff #53509)

Not a bad idea, I will keep it in mind for a followup