Page MenuHomeFreeBSD

readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding
ClosedPublic

Authored by emaste on Feb 1 2019, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 7:06 PM
Unknown Object (File)
Mon, Mar 4, 12:35 AM
Unknown Object (File)
Feb 4 2024, 8:46 PM
Unknown Object (File)
Jan 16 2024, 5:16 AM
Unknown Object (File)
Dec 20 2023, 12:29 AM
Unknown Object (File)
Dec 11 2023, 1:33 AM
Unknown Object (File)
Nov 8 2023, 9:15 PM
Unknown Object (File)
Nov 4 2023, 2:35 AM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks added a subscriber: brooks.

LGTM

contrib/elftoolchain/readelf/readelf.c
2741 ↗(On Diff #53509)

Would this make more sense to the user as something like:

printf(" unknown(0x%jx)", (uintmax_t)val);
This revision is now accepted and ready to land.Feb 1 2019, 6:18 PM
kib added inline comments.
contrib/elftoolchain/readelf/readelf.c
2736 ↗(On Diff #53509)

This is weird, why not do &= ~ ?

2741 ↗(On Diff #53509)

It would make more sense to print each unknown flag individually. At least I do find it more useful, from my experience with the Intel CPUID bits and DMAR capabilities reports.

This revision was automatically updated to reflect the committed changes.
contrib/elftoolchain/readelf/readelf.c
2741 ↗(On Diff #53509)

Not a bad idea, I will keep it in mind for a followup